From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjZCF-0001Zk-Ew for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:23:39 -0500 Received: from [199.232.76.173] (port=33492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjZCF-0001ZZ-4f for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:23:39 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjZCE-0003ge-Fe for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:23:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58807) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjZCD-0003gQ-VT for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:23:38 -0500 Message-ID: <4B829364.7020300@redhat.com> Date: Mon, 22 Feb 2010 16:23:32 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20100222135906.347393434@amt.cnet> <20100222140210.130087300@amt.cnet> In-Reply-To: <20100222140210.130087300@amt.cnet> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: > Cc: "Michael S. Tsirkin" > Signed-off-by: Marcelo Tosatti > > Index: qemu/kvm-all.c > =================================================================== > --- qemu.orig/kvm-all.c > +++ qemu/kvm-all.c > @@ -718,6 +718,9 @@ static int kvm_handle_io(uint16_t port, > return 1; > } > > +/* FIXME: arch dependant, x86 version */ > +#define smp_wmb() asm volatile("" ::: "memory") > + > sfence? what about other arches? -- error compiling committee.c: too many arguments to function