From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NjZMg-0004oL-OT
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:34:26 -0500
Received: from [199.232.76.173] (port=60581 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NjZMg-0004oD-Dc
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:34:26 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <agraf@suse.de>) id 1NjZMe-0004MV-UH
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:34:26 -0500
Received: from cantor.suse.de ([195.135.220.2]:37183 helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1NjZMe-0004M9-LG
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:34:24 -0500
Message-ID: <4B8295EB.5080003@suse.de>
Date: Mon, 22 Feb 2010 15:34:19 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug
References: <ee2e06e91002200208t4bfb6c10rbb797e09cfd712e4@mail.gmail.com>
	<f43fc5581002200232h72ac0f7erc0ee7cd4f92a4250@mail.gmail.com>
In-Reply-To: <f43fc5581002200232h72ac0f7erc0ee7cd4f92a4250@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Jay Foad <jay.foad@gmail.com>, qemu-devel@nongnu.org

Blue Swirl wrote:
> Thanks, applied.
>  =20

This patch breaks building on ppc32. Reverting it makes it compile again:

In file included from /suse/agraf/git/qemu/tcg/tcg.c:158:
/suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error:
=E2=80=98INDEX_op_qemu_ld32s=E2=80=99 undeclared here (not in a function)


Alex

> On 2/20/10, Jay Foad <jay.foad@gmail.com> wrote:
>  =20
>> On 32-bit hosts op_qemu_ld32s is unused. Remove it to fix the
>>  following assertion failure:
>>
>>  qemu-alpha: tcg/tcg.c:1055:
>>  tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed.
>>
>>  Signed-off-by: Jay Foad <jay.foad@gmail.com>
>>  ---
>>   tcg/tcg-opc.h |    5 -----
>>   1 files changed, 0 insertions(+), 5 deletions(-)
>>
>>  diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h
>>  index 89db3b4..838f1f4 100644
>>  --- a/tcg/tcg-opc.h
>>  +++ b/tcg/tcg-opc.h
>>  @@ -224,11 +224,6 @@ DEF2(qemu_ld32u, 1, 1, 1, TCG_OPF_CALL_CLOBBER |
>>  TCG_OPF_SIDE_EFFECTS)
>>   DEF2(qemu_ld32u, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECT=
S)
>>   #endif
>>   #if TARGET_LONG_BITS =3D=3D 32
>>  -DEF2(qemu_ld32s, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECT=
S)
>>  -#else
>>  -DEF2(qemu_ld32s, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECT=
S)
>>  -#endif
>>  -#if TARGET_LONG_BITS =3D=3D 32
>>   DEF2(qemu_ld64, 2, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS=
)
>>   #else
>>   DEF2(qemu_ld64, 2, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS=
)
>>
>>
>>
>>    =20
>
>
>  =20