qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Naphtali Sprei <nsprei@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [BUG] Regression: readonly raw images no longer work
Date: Mon, 22 Feb 2010 16:39:33 +0200	[thread overview]
Message-ID: <4B829725.4050203@redhat.com> (raw)
In-Reply-To: <4B771C34.4040308@mail.berlios.de>

Stefan Weil wrote:
> This command used to work, but fails now:
> 
> $ i386-softmmu/qemu -snapshot /dev/sda
> qemu: could not open disk image /dev/sda: Permission denied
> 
> $ ls -l /dev/sda
> brw-rw-r-- 1 root disk 8, 0 13. Feb 08:55 /dev/sda
> 
> The original file of a snapshot needs only read access,
> but QEMU tries read/write access and fails.
> 
> Variants of above command using -hda or -drive
> also fail with the same error message.
> 
> I did not test whether the regression affects other
> kinds of images, too. Maybe only raw images trigger
> no longer work.
> 
> Regards
> Stefan Weil
> 
> 
> 

Sorry for the late reply,
this is my fault. It will fail for any image format.

It's already fixed with commit 4dca4b639cb20fee38f6eec0a391aecc0ad8848d :
"block: more read-only changes, related to backing files"

Now, since the /dev/sda is the backing-file, it's opened as read-only, no permission problem.

Notice that if you try to commit your changes to the read-only disk (in monitor command), 
it will be silently ignored, no error or warning displayed.
Should I add a warning/error printing ? 

 Naphtali

      parent reply	other threads:[~2010-02-22 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-13 21:40 [Qemu-devel] [BUG] Regression: readonly raw images no longer work Stefan Weil
2010-02-13 22:38 ` [Qemu-devel] " Paolo Bonzini
2010-02-15  8:01   ` Markus Armbruster
2010-02-22 14:39 ` Naphtali Sprei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B829725.4050203@redhat.com \
    --to=nsprei@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).