From: Alexander Graf <agraf@suse.de>
To: Jay Foad <jay.foad@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug
Date: Mon, 22 Feb 2010 16:23:24 +0100 [thread overview]
Message-ID: <4B82A16C.6090808@suse.de> (raw)
In-Reply-To: <ee2e06e91002220642j295a4867p6af4efa4499c5a71@mail.gmail.com>
Jay Foad wrote:
>> This patch breaks building on ppc32. Reverting it makes it compile again:
>>
>
>
>> /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error:
>> ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function)
>>
>
> Does it build if you remove line 1696? If so, I'd suggest doing that.
>
Yes, that fixes it. Please grep through all tcg targets and send a patch
removing all references to ld32s if you think it's not necessary.
Alex
next prev parent reply other threads:[~2010-02-22 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 10:08 [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug Jay Foad
2010-02-20 10:32 ` Blue Swirl
2010-02-22 14:34 ` Alexander Graf
2010-02-22 14:42 ` Jay Foad
2010-02-22 15:22 ` Stefan Weil
2010-02-22 16:43 ` [Qemu-devel] [PATCH] tcg/ppc: Add missing conditional compilation Stefan Weil
2010-02-22 17:09 ` malc
2010-02-22 15:23 ` Alexander Graf [this message]
2010-02-22 15:55 ` [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug Jay Foad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B82A16C.6090808@suse.de \
--to=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=jay.foad@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).