From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjzLH-0002yn-AC for qemu-devel@nongnu.org; Tue, 23 Feb 2010 13:18:43 -0500 Received: from [199.232.76.173] (port=43971 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjzLG-0002yf-UF for qemu-devel@nongnu.org; Tue, 23 Feb 2010 13:18:43 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjzLE-0004al-H2 for qemu-devel@nongnu.org; Tue, 23 Feb 2010 13:18:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59763) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjzLD-0004aQ-TM for qemu-devel@nongnu.org; Tue, 23 Feb 2010 13:18:40 -0500 Message-ID: <4B841BFA.8010609@redhat.com> Date: Tue, 23 Feb 2010 19:18:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <4B841757.3070808@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: gcc 4.4 miscompiling cpu_exec() ? List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jay Foad Cc: qemu-devel@nongnu.org On 02/23/2010 07:17 PM, Jay Foad wrote: >> Can you try this patch: > > It works! Thanks. > >> and if it works, possibly only each hunk of it? > > Just the first hunk: works! > Just the second hunk: doesn't work > > Can you explain why the volatile is necessary? Or is it working around > a problem with the compiler? I don't know exactly without checking, but these were the main changes introduced by my 24ebf5f31a178051cff1a4aab5ba621037191577 patch. I'll send it out shortly. Paolo