From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NkFN6-0002Mm-Ku
	for qemu-devel@nongnu.org; Wed, 24 Feb 2010 06:25:40 -0500
Received: from [199.232.76.173] (port=50557 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NkFN5-0002MS-2S
	for qemu-devel@nongnu.org; Wed, 24 Feb 2010 06:25:39 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <rth7680@gmail.com>) id 1NkFN4-0001wf-9D
	for qemu-devel@nongnu.org; Wed, 24 Feb 2010 06:25:38 -0500
Received: from mail-bw0-f218.google.com ([209.85.218.218]:39206)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth7680@gmail.com>) id 1NkFN3-0001wZ-Uy
	for qemu-devel@nongnu.org; Wed, 24 Feb 2010 06:25:38 -0500
Received: by bwz10 with SMTP id 10so12967bwz.2
	for <qemu-devel@nongnu.org>; Wed, 24 Feb 2010 03:25:36 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4B850C87.8060101@twiddle.net>
Date: Wed, 24 Feb 2010 12:24:55 +0100
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/6] target-alpha: fpu qualifiers, round
 2
References: <4B2BFD85.6070702@twiddle.net>
	<cover.1262645165.git.rth@twiddle.net>
	<20100223225825.GS10348@hall.aurel32.net>
In-Reply-To: <20100223225825.GS10348@hall.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: laurent.desnogues@gmail.com, qemu-devel@nongnu.org

On 02/23/2010 02:58 PM, Aurelien Jarno wrote:
>> I have totally rewritten the patch to be more along the line
>> that Laurent was suggesting, in that the rounding mode and other
>> qualifiers are totally parsed within the translator.  I no longer
>> pass the FN11 field to the helper functions.
>
> What's the benefit of doing that? I don't say it's wrong, I just want
> to understand. Otherwise the patch looks good, so it can probably be
> applied without any change.

I seem to recall Laurent opining that doing the interpretation
of the opcode in two different places was less than clean, and
in the end I agree with him.

FWIW, this configuration would also be compatible with a
future TCG enhancement to generate fp code, whereas the first
config would not.


r~