From: Paolo Bonzini <pbonzini@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 4/4] kbd keds: vnc
Date: Thu, 25 Feb 2010 12:11:54 +0100 [thread overview]
Message-ID: <4B865AFA.3020807@redhat.com> (raw)
In-Reply-To: <m3zl2xpogf.fsf@trasno.mitica>
On 02/25/2010 12:03 PM, Juan Quintela wrote:
>> > + caps = ledstate & QEMU_CAPS_LOCK_LED ? 1 : 0;
>> > + num = ledstate & QEMU_NUM_LOCK_LED ? 1 : 0;
> I think it is clearer to use a bool.
>
> bool caps = ledstate& QEMU_CAPS_LOCK_LED;
Are we assuming a C99 bool elsewhere? For example, I see only uses of
bool like
hw/eepro100.c: bool bit_el = ((command & 0x8000) != 0);
So yet another choice is
caps = (ledstate & QEMU_CAPS_LOCK_LED) != 0;
Paolo
next prev parent reply other threads:[~2010-02-25 11:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 8:39 [Qemu-devel] [PATCH 0/4] keyboard led status tracking Gerd Hoffmann
2010-02-25 8:39 ` [Qemu-devel] [PATCH 1/4] kbd leds: infrastructure Gerd Hoffmann
2010-02-25 10:57 ` [Qemu-devel] " Juan Quintela
2010-02-25 14:15 ` [Qemu-devel] " Anthony Liguori
2010-02-25 14:36 ` Gerd Hoffmann
2010-02-25 15:07 ` Anthony Liguori
2010-02-25 16:51 ` Gerd Hoffmann
2010-02-25 17:05 ` Anthony Liguori
2010-02-25 8:39 ` [Qemu-devel] [PATCH 2/4] kbd leds: ps/2 kbd Gerd Hoffmann
2010-02-25 10:59 ` [Qemu-devel] " Juan Quintela
2010-02-25 8:39 ` [Qemu-devel] [PATCH 3/4] kbd leds: usb kbd Gerd Hoffmann
2010-02-25 8:39 ` [Qemu-devel] [PATCH 4/4] kbd keds: vnc Gerd Hoffmann
2010-02-25 11:03 ` [Qemu-devel] " Juan Quintela
2010-02-25 11:11 ` Paolo Bonzini [this message]
2010-02-26 16:05 ` Gerd Hoffmann
2010-02-28 1:38 ` [Qemu-devel] " Paul Brook
2010-03-01 8:12 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B865AFA.3020807@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).