From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NkdVC-0007VY-NK
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 08:11:38 -0500
Received: from [199.232.76.173] (port=37450 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NkdVC-0007VK-8Q
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 08:11:38 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <pbonzini@redhat.com>) id 1NkdVB-0003TY-HH
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 08:11:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23766)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1NkdVA-0003SF-Tk
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 08:11:37 -0500
Message-ID: <4B867703.8000609@redhat.com>
Date: Thu, 25 Feb 2010 14:11:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <f43fc5581002181107w7bb19d2cye08e931b6401d4db@mail.gmail.com>
	<1266524723-21572-1-git-send-email-pbonzini@redhat.com>
	<1266524723-21572-2-git-send-email-pbonzini@redhat.com>
	<f43fc5581002181328x31d0ab1l7ab09fa530c24781@mail.gmail.com>
	<20100225114048.GB9116@redhat.com> <4B867230.60708@redhat.com>
	<20100225130427.GA10660@redhat.com>
In-Reply-To: <20100225130427.GA10660@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 02/25/2010 02:04 PM, Michael S. Tsirkin wrote:
>> Clobbering memory
>> >  is not necessary since we are only caring about blocking assignments of
>> >  "env", which is by definition in a register
>
> Then I think you should add that as a clobber. Otherwise what prevents the
> compiler from reordering this asm wrt assignments?

That old-style asms block scheduling of _anything_ across it (like 
"barrier()" in the Linux kernel).  So, it is actually slightly stricter 
than what was there before.

I should have made clear in the commit message that this is the only 
change wrt hostregs_helper.h.

Paolo