From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nkgvr-0007JX-Us
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 11:51:23 -0500
Received: from [199.232.76.173] (port=35545 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nkgvr-0007JP-HW
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 11:51:23 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1Nkgvq-0007kg-88
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 11:51:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56208)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Nkgvp-0007kW-Qh
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 11:51:22 -0500
Message-ID: <4B86AA76.6050205@redhat.com>
Date: Thu, 25 Feb 2010 17:51:02 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] kbd leds: infrastructure
References: <1267087161-15204-1-git-send-email-kraxel@redhat.com>
	<1267087161-15204-2-git-send-email-kraxel@redhat.com>
	<4B8685EC.20000@codemonkey.ws> <4B868AFC.3060904@redhat.com>
	<4B869244.70204@codemonkey.ws>
In-Reply-To: <4B869244.70204@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 02/25/10 16:07, Anthony Liguori wrote:
> On 02/25/2010 08:36 AM, Gerd Hoffmann wrote:
>> I don't think so. Devil is in the details. Note that kbd_event and
>> mouse_event go to the kbd/mouse drivers, whereas led_event comes from
>> the kbd driver, so they are different albeit related beasts.
>
> Right, I hadn't thought it through enough.
>
> Should led events be part of DisplayChangeListener? I think you could
> make the argument that it's part of the display state.

 From a hardware point of view display and keyboard are not related at 
all.  The keyboard drivers don't have a DisplayState pointer at hand for 
that reason.  So I don't think this makes sense, even though remote 
desktop protocols typically transport both display and keyboard data.

cheers,
   Gerd