From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nkh9w-000560-4n
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 12:05:56 -0500
Received: from [199.232.76.173] (port=40246 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nkh9v-00055g-Db
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 12:05:55 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Nkh9u-0000Kw-2y
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 12:05:55 -0500
Received: from mail-qy0-f201.google.com ([209.85.221.201]:43992)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Nkh9r-0000KP-IY
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 12:05:53 -0500
Received: by qyk39 with SMTP id 39so1137564qyk.22
	for <qemu-devel@nongnu.org>; Thu, 25 Feb 2010 09:05:47 -0800 (PST)
Message-ID: <4B86ADE7.6050708@codemonkey.ws>
Date: Thu, 25 Feb 2010 11:05:43 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] kbd leds: infrastructure
References: <1267087161-15204-1-git-send-email-kraxel@redhat.com>
	<1267087161-15204-2-git-send-email-kraxel@redhat.com>
	<4B8685EC.20000@codemonkey.ws> <4B868AFC.3060904@redhat.com>
	<4B869244.70204@codemonkey.ws> <4B86AA76.6050205@redhat.com>
In-Reply-To: <4B86AA76.6050205@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/25/2010 10:51 AM, Gerd Hoffmann wrote:
> On 02/25/10 16:07, Anthony Liguori wrote:
>> On 02/25/2010 08:36 AM, Gerd Hoffmann wrote:
>>> I don't think so. Devil is in the details. Note that kbd_event and
>>> mouse_event go to the kbd/mouse drivers, whereas led_event comes from
>>> the kbd driver, so they are different albeit related beasts.
>>
>> Right, I hadn't thought it through enough.
>>
>> Should led events be part of DisplayChangeListener? I think you could
>> make the argument that it's part of the display state.
>
> From a hardware point of view display and keyboard are not related at 
> all.  The keyboard drivers don't have a DisplayState pointer at hand 
> for that reason.  So I don't think this makes sense, even though 
> remote desktop protocols typically transport both display and keyboard 
> data.

Fair enough.

Regards,

Anthony Liguori

> cheers,
>   Gerd
>