From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] qdev: Catch attempt to attach more than one device to a netdev
Date: Fri, 26 Feb 2010 11:05:52 +0100 [thread overview]
Message-ID: <4B879D00.5070400@redhat.com> (raw)
In-Reply-To: <m3pr3s9wdq.fsf@blackfin.pond.sub.org>
On 02/26/10 10:30, Markus Armbruster wrote:
> This made a lot of sense if each parser threw largely different errors.
> Which isn't the case: we have one so far ("failed to parse"), and we
> just encountered a use for a second.
There are actually three: parse error, not found
(netdev=<does-not-exist>) and busy (netdev=<already-in-use>).
But, yes, given the small number of error cases it makes sense to
generate the error one layer up and not in the parsers themself.
cheers,
Gerd
next prev parent reply other threads:[~2010-02-26 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 10:10 [Qemu-devel] [PATCH] qdev: Catch attempt to attach more than one device to a netdev Markus Armbruster
2010-02-25 11:42 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-25 12:07 ` Markus Armbruster
2010-02-25 12:08 ` Michael S. Tsirkin
2010-02-25 12:49 ` Markus Armbruster
2010-02-25 14:32 ` Markus Armbruster
2010-02-25 14:38 ` Gerd Hoffmann
2010-02-26 9:30 ` Markus Armbruster
2010-02-26 10:05 ` Gerd Hoffmann [this message]
2010-02-26 14:41 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B879D00.5070400@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).