From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nkx5B-0006Qa-2l
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 05:06:05 -0500
Received: from [199.232.76.173] (port=35055 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nkx59-0006QS-Ft
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 05:06:03 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1Nkx58-000824-Ox
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 05:06:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21394)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Nkx58-000820-Cz
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 05:06:02 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QA60pJ030766
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2010 05:06:00 -0500
Message-ID: <4B879D00.5070400@redhat.com>
Date: Fri, 26 Feb 2010 11:05:52 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <m3fx4pwrqw.fsf@blackfin.pond.sub.org>	<20100225114256.GC9116@redhat.com>	<m3vddlr011.fsf@blackfin.pond.sub.org>	<20100225120848.GA9223@redhat.com>	<m3eik9mln2.fsf@blackfin.pond.sub.org>
	<4B868B6F.8050900@redhat.com>
	<m3pr3s9wdq.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3pr3s9wdq.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qdev: Catch attempt to attach more than
 one device to a netdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 02/26/10 10:30, Markus Armbruster wrote:
> This made a lot of sense if each parser threw largely different errors.
> Which isn't the case: we have one so far ("failed to parse"), and we
> just encountered a use for a second.

There are actually three:  parse error, not found 
(netdev=<does-not-exist>) and busy (netdev=<already-in-use>).

But, yes, given the small number of error cases it makes sense to 
generate the error one layer up and not in the parsers themself.

cheers,
   Gerd