From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NkztD-0006jb-UX for qemu-devel@nongnu.org; Fri, 26 Feb 2010 08:05:56 -0500 Received: from [199.232.76.173] (port=37807 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkztC-0006jS-El for qemu-devel@nongnu.org; Fri, 26 Feb 2010 08:05:54 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NkztB-0005fO-Lo for qemu-devel@nongnu.org; Fri, 26 Feb 2010 08:05:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18518) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NkztB-0005fG-9Q for qemu-devel@nongnu.org; Fri, 26 Feb 2010 08:05:53 -0500 Message-ID: <4B87C724.1030507@redhat.com> Date: Fri, 26 Feb 2010 14:05:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/2] simplify global register save/restore References: <1265844362-29836-1-git-send-email-pbonzini@redhat.com> <201002261130.30888.paul@codesourcery.com> In-Reply-To: <201002261130.30888.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 02/26/2010 12:30 PM, Paul Brook wrote: >> Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global >> register that is actually used is AREG0, so the complexity of >> hostregs_helper.h is unwarranted. >> >> Let's just say that env should be the only global register. AREG1 and >> AREG2 in principle could still be used to work around bad register >> allocation in GCC, so I'm leaving them in dyngen-exec.h. > > I think AREG[12] should be removed too. If we aren't saving them then they > can't be safely used. You could still use them for local register variables, but I can prepare a patch to remove them (unless you do that yourself). Paolo