From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nl2h1-0001FY-QB
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 11:05:31 -0500
Received: from [199.232.76.173] (port=56101 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nl2h0-0001Ec-EA
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 11:05:30 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1Nl2gz-0003Go-Ix
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 11:05:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9539)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Nl2gz-0003Fv-55
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 11:05:29 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QG5RHK010675
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2010 11:05:28 -0500
Message-ID: <4B87F142.1030409@redhat.com>
Date: Fri, 26 Feb 2010 17:05:22 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1267087161-15204-1-git-send-email-kraxel@redhat.com>	<1267087161-15204-5-git-send-email-kraxel@redhat.com>
	<m3zl2xpogf.fsf@trasno.mitica>
In-Reply-To: <m3zl2xpogf.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/4] kbd keds: vnc
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

>> +    int caps, num;
>
> I think it is clearer to use a bool.
>
>     bool caps = ledstate&  QEMU_CAPS_LOCK_LED;

Indeed.

>> +    if (vs->modifiers_state[0x3a] != caps) {
>> +        vs->modifiers_state[0x3a] = caps;
>
> modifiers_state type needs to go from uint8_t to bool.  It simplifies
> lots of !!foo around.  But the change is independent of this series.

But mixing uin8_t and bool doesn't look sane to me.  So I think I stay 
with uin8_t to match modifiers_state type.

cheers,
   Gerd