From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nl8Ww-00008r-W0
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 17:19:31 -0500
Received: from [199.232.76.173] (port=45378 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nl8Ww-00008j-BZ
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 17:19:30 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <daahern@cisco.com>) id 1Nl8Wt-0000pO-LG
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 17:19:30 -0500
Received: from sj-iport-5.cisco.com ([171.68.10.87]:1838)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <daahern@cisco.com>) id 1Nl8Wt-0000p4-4q
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 17:19:27 -0500
Message-ID: <4B8848E7.4010401@cisco.com>
Date: Fri, 26 Feb 2010 15:19:19 -0700
From: "David S. Ahern" <daahern@cisco.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based
	monitor
References: <20100226093456.GA17347@redhat.com>
	<20100226200414.GA25277@redhat.com>
In-Reply-To: <20100226200414.GA25277@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shahar Havivi <shaharh@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, qemu-devel@nongnu.org





On 02/26/2010 01:04 PM, Shahar Havivi wrote:
> Fix codding style
> ---
>  qemu-char.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 4169492..4533887 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed,
>             speed, parity, data_bits, stop_bits);
>  #endif
>      tcgetattr (fd, &tty);
> +    oldtty = tty;
> 
>  #define check_speed(val) if (speed <= val) { spd = B##val; break; }
>      speed = speed * 10 / 11;
> @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
>      return 0;
>  }
> 
> +static void tty_exit(void)
> +{
> +    tcsetattr(0, TCSANOW, &oldtty);
> +}
> +
>  static void qemu_chr_close_tty(CharDriverState *chr)
>  {
>      FDCharDriver *s = chr->opaque;
> @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>      }
>      chr->chr_ioctl = tty_serial_ioctl;
>      chr->chr_close = qemu_chr_close_tty;
> +    if (!term_atexit_done++) {
> +        atexit(tty_exit);
> +    }
>      return chr;
>  }
>  #else  /* ! __linux__ && ! __sun__ */
> --
> 1.6.3.3
> 

If qemu is invoked with both stdio and one or more host tty's only the
last one referenced is reset one exit. Also, shouldn't the attributes be
reset when the device is closed as opposed to exit? ie., a device
connected to a tty chardev is removed via the monitor.

David