From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nm0jm-0003Gl-J0 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:12:23 -0500 Received: from [199.232.76.173] (port=60922 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nm0jl-0003GM-U9 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:12:22 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nm0jl-0002Od-7H for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:12:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16995) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nm0jk-0002OV-Q8 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:12:21 -0500 Message-ID: <4B8B76D5.5080602@redhat.com> Date: Mon, 01 Mar 2010 09:12:05 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/4] kbd keds: vnc References: <1267087161-15204-1-git-send-email-kraxel@redhat.com> <1267087161-15204-5-git-send-email-kraxel@redhat.com> <201002280138.04634.paul@codesourcery.com> In-Reply-To: <201002280138.04634.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 02/28/10 02:38, Paul Brook wrote: >> Usually guests use the keyboard leds to signal the capslock and numlock >> state to the user, so we can use this to better keep track of capslock >> and numlock state in the qemu vnc server. > > Isn't this going to break horribly when my guest starts flashing the capslock > light in response to network traffic? Yes, if the guest plays blinkenlights with the keyboard leds this breaks. I've considered adding option to turn this off, but then decided to wait and see whenever it actually is a problem in practice. The only common case I'm aware of is the linux kernel panic blinking. I'll add a option to turn this off if you think we'll need one. cheers, Gerd