From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nm5Lk-0004az-KP for qemu-devel@nongnu.org; Mon, 01 Mar 2010 08:07:52 -0500 Received: from [199.232.76.173] (port=56233 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nm5Lj-0004ZO-Ty for qemu-devel@nongnu.org; Mon, 01 Mar 2010 08:07:51 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nm5Lh-0006us-Mp for qemu-devel@nongnu.org; Mon, 01 Mar 2010 08:07:51 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:62981) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nm5Lh-0006ug-CT for qemu-devel@nongnu.org; Mon, 01 Mar 2010 08:07:49 -0500 Received: by ewy19 with SMTP id 19so1901225ewy.2 for ; Mon, 01 Mar 2010 05:07:47 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4B8BB6DD.7090807@redhat.com> Date: Mon, 01 Mar 2010 13:45:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1267034160-3517-1-git-send-email-armbru@redhat.com> <1267034160-3517-13-git-send-email-armbru@redhat.com> <20100226164354.6be8466d@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH RFC 12/48] error: New error_printf() and error_vprintf() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Luiz Capitulino On 03/01/2010 09:54 AM, Markus Armbruster wrote: > Luiz Capitulino writes: > >> On Wed, 24 Feb 2010 18:55:24 +0100 >> Markus Armbruster wrote: >> >>> FIXME They should return int, so callers can calculate width. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> qemu-error.c | 49 ++++++++++++++++++++++++++++++++++++++++++------- >>> qemu-error.h | 14 ++++++++++++++ >>> 2 files changed, 56 insertions(+), 7 deletions(-) >>> >>> diff --git a/qemu-error.c b/qemu-error.c >>> index 63bcdcf..76c660a 100644 >>> --- a/qemu-error.c >>> +++ b/qemu-error.c >>> @@ -1,18 +1,53 @@ >>> +/* >>> + * Error reporting >>> + * >>> + * Copyright (C) 2010 Red Hat Inc. >>> + * >>> + * Authors: >>> + * Markus Armbruster, >>> + * >>> + * This work is licensed under the terms of the GNU GPL, version 2 or later. >>> + * See the COPYING file in the top-level directory. >>> + */ >>> + >>> #include >>> #include "monitor.h" >>> #include "sysemu.h" >>> >>> -void qemu_error(const char *fmt, ...) >>> +/* >>> + * Print to current monitor if we have one, else to stderr. >>> + * FIXME should return int, so callers can calculate width, but that >>> + * requires surgery to monitor_printf(). Left for another day. >>> + */ >>> +void error_vprintf(const char *fmt, va_list ap) >>> { >>> - va_list args; >>> - >>> - va_start(args, fmt); >>> if (cur_mon) { >>> - monitor_vprintf(cur_mon, fmt, args); >>> + monitor_vprintf(cur_mon, fmt, ap); >>> } else { >>> - vfprintf(stderr, fmt, args); >>> + vfprintf(stderr, fmt, ap); >>> } >>> - va_end(args); >>> +} >> >> This can be static. > > Yes. But why would that be useful? It's neither a name space pollution > nor does it poke a hole into an abstraction. > >>> + >>> +/* >>> + * Print to current monitor if we have one, else to stderr. >>> + * FIXME just like error_vprintf() >>> + */ >>> +void error_printf(const char *fmt, ...) >>> +{ >>> + va_list ap; >>> + >>> + va_start(ap, fmt); >>> + error_vprintf(fmt, ap); >>> + va_end(ap); >>> +} >> >> This function's name is inconsistent with qemu_error() and >> qemu_error_new(). > > I'm fond of prepending qemu_ to random symbols left and right. Yes, I > know I'm reading QEMU source code, thank you :) > > If the names here are really important: What about stripping qemu_ from > qemu_error()& friends? Since we are at it, qemu_error_new could be renamed to qerror_raise or error_raise (since it returns void). Not worthwhile if you're not changing the name already, but in that case... Paolo