From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nmoze-00036T-3F
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 08:52:06 -0500
Received: from [199.232.76.173] (port=40106 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nmozd-00036L-P7
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 08:52:05 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kwolf@redhat.com>) id 1Nmozd-0002Qv-1g
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 08:52:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54371)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1Nmozc-0002QR-M2
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 08:52:04 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o23Dq1A6027207
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 3 Mar 2010 08:52:01 -0500
Message-ID: <4B8E6955.6030900@redhat.com>
Date: Wed, 03 Mar 2010 14:51:17 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <cover.1267617582.git.quintela@redhat.com>
	<df5d2141b01156f489600d559fa758c7e1ab1745.1267617582.git.quintela@redhat.com>
In-Reply-To: <df5d2141b01156f489600d559fa758c7e1ab1745.1267617582.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 06/10] vl: exit if we are not able to write
	into the pipe
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org

Am 03.03.2010 13:06, schrieb Juan Quintela:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  vl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index db7a178..119c7e4 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5745,6 +5745,7 @@ int main(int argc, char **argv, char **envp)
>              uint8_t status = 1;
>              if (write(fds[1], &status, 1) != 1) {
>                  perror("daemonize. Writing to pipe\n");
> +                exit(1);
>              }
>          } else
>  #endif

This is already the handling code for a fatal error, it's just trying to
tell the parent process that it went wrong. Completing the context:

            fprintf(stderr, "Could not acquire pid file: %s\n",
strerror(errno));
        exit(1);
    }

So there is already an exit(1), this patch doesn't change anything.

Kevin