From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nmu2c-0004qc-Ib
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 14:15:30 -0500
Received: from [199.232.76.173] (port=45282 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nmu2c-0004qP-4b
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 14:15:30 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <weil@mail.berlios.de>) id 1Nmu2b-00028q-1J
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 14:15:30 -0500
Received: from moutng.kundenserver.de ([212.227.126.186]:55705)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1Nmu2a-00028k-J6
	for qemu-devel@nongnu.org; Wed, 03 Mar 2010 14:15:28 -0500
Message-ID: <4B8EB53D.2010903@mail.berlios.de>
Date: Wed, 03 Mar 2010 20:15:09 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <4B7821AC.6080400@mail.berlios.de>
	<1267565880-18382-19-git-send-email-weil@mail.berlios.de>
	<20100303114735.GB15278@redhat.com>
In-Reply-To: <20100303114735.GB15278@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCHv3 19/20] eepro100: Remove C++ comments
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Michael S. Tsirkin schrieb:
> On Tue, Mar 02, 2010 at 10:37:59PM +0100, Stefan Weil wrote:
>> C++ comments are unwanted, so this is fixed here.
>>
>> * Replace C++ comments by C comments.
>> * Put code which was deactivated by a C++ comment in #if 0...#endif.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>
> It would be nice to add some documentation to commented
> blocks, explaining why we still keep them around
> and what happens if they are uncommented.


Typically, later patches either use this deactivated code (maybe after
some modifications), or they remove it completely. More documentation
would help of course - I'll try my best :-)

The purpose of this patch was only elimination of C++ comments by formally
transforming them to either C comments or by using the preprocessor #if.