From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nn6rH-000340-0y
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 03:56:39 -0500
Received: from [199.232.76.173] (port=58757 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nn6rF-00033S-Aq
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 03:56:37 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1Nn6rE-00036L-9S
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 03:56:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22719)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Nn6rD-000362-PV
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 03:56:36 -0500
Message-ID: <4B8F75BC.8000800@redhat.com>
Date: Thu, 04 Mar 2010 09:56:28 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices
	to pci.c
References: <4B7821AC.6080400@mail.berlios.de>	<1266164189-21062-1-git-send-email-weil@mail.berlios.de>	<1266164189-21062-2-git-send-email-weil@mail.berlios.de>	<1266164189-21062-3-git-send-email-weil@mail.berlios.de>	<1266164189-21062-4-git-send-email-weil@mail.berlios.de>	<1266164189-21062-5-git-send-email-weil@mail.berlios.de>	<20100221170021.GA5185@redhat.com>	<4B81A0E1.5030300@mail.berlios.de>	<20100303115111.GD15278@redhat.com>
	<4B8E64C9.10406@redhat.com>	<20100303133348.GA21663@redhat.com>
	<4B8EB018.6050101@mail.berlios.de>
In-Reply-To: <4B8EB018.6050101@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On 03/03/10 19:53, Stefan Weil wrote:
> This would indeed simplify the code.
>
> Although I don't like tricky programming like DO_UPCAST
> (because I saw too much code where tricky programming
> was faulty programming),

Yea, when coding C++ in C you need little tricks now and then ;)

You need that in one place only though, nic_init() can store a pointer 
in EEPRO100State and everybody can take the direct route then ...

>>> qdev has aliases. You can add .qdev.alias = "eepro100" to one of the
>>> variants, then the eepro100 name will work as well.
>
> Good idea. To keep the number of aliases small, I plan to
> add only one or two aliases: e100 (eepro100 only if a second
> alias is possible).

You can have one alias only.

> Why? e100 is the current linux driver name.

Reasonable choice, lines up with e1000.

> eepro100 was the former linux driver name.

And leaked into a bunch of places (like qemu source code) because of 
that.  Probably only developers recognize the name though.

> The marketing name was Intel EtherExpress Pro 100.
> I agree that it would help people to see this name,
> so I suggest adding it to qemu-doc.texi.

Maybe .desc too ?

cheers,
   Gerd