From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NnHA4-0004iF-CZ
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 14:56:44 -0500
Received: from [199.232.76.173] (port=49111 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NnHA3-0004hw-Uh
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 14:56:43 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <weil@mail.berlios.de>) id 1NnHA2-0006Ec-1l
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 14:56:43 -0500
Received: from moutng.kundenserver.de ([212.227.126.171]:50970)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1NnHA1-0006E4-Fn
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 14:56:41 -0500
Message-ID: <4B901066.1070903@mail.berlios.de>
Date: Thu, 04 Mar 2010 20:56:22 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1267726847.5322.40.camel@localhost.localdomain>
	<4B9006E4.7090507@codemonkey.ws>
In-Reply-To: <4B9006E4.7090507@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Build failure for upstream qemu 04-03-2010
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Anthony Liguori schrieb:
> It was broken by:
>
> commit da51e79b7ff2126cc2448749d657a4f6e3b1270f
> Author: Stefan Weil <weil@mail.berlios.de>
> Date:   Tue Mar 2 22:37:44 2010 +0100
>
>     eepro100: Support gpxe boot for all eepro100 devices
>
>     Only two boot ROM files are needed for all devices.
>
>     * Add these GPXE ROM files using new naming convention
>       (as discussed on qemu-devel). Both files were created
>       with http://rom-o-matic.net/, PCI vendor / device ids
>       as in ROM filenames and option BANNER_TIMEOUT = 0.
>
>     * Remove old PXE ROM file for i82559er.
>       It was replaced by gpxe-eepro100-80861209.rom.
>
>     * Update pc-bios/README (and sort entries).
>
>     Full support still needs additional eepro100 fixes.
>
>     Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> Stefan/Michael, can you please submit a fix?  The Makefile wasn't
> adjusted for the new PXE naming.
>
> Really, the roms should not have been renamed like this in this sort
> of patch.  If we switch to gpxe as a prefix, we should rename all of
> the roms at once as opposed to having some roms with a pxe name and
> others with gpxe.
>
> Regards,
>
> Anthony Liguori

Hi Antony,

sorry for the missing change in Makefile.
I'll send a patch which fixes that.

The new naming scheme was an RFC on qemu-devel.
I had to choose some name (because now there are two
instead of one ROM files for eepro100.c, and the
choosen names are the result from the discussion.

I agree that all ROM files with GPXE should have
gpxe-names, but there is no need to do this in
one step.

Regards,
Stefan Weil