From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NoE3d-0000rg-Ui for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:50:02 -0500 Received: from [199.232.76.173] (port=33467 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NoE3c-0000rU-KS for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:50:00 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NoE3b-0003Gr-Fj for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:50:00 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:40438) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NoE3b-0003Gg-4g for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:49:59 -0500 Message-ID: <4B938494.1040100@web.de> Date: Sun, 07 Mar 2010 11:48:52 +0100 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH] Avoid crash on '-usbdevice ' without parameters List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel Many usbdevice_init implementors assume params is non-NULL. Signed-off-by: Jan Kiszka --- hw/usb-bus.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 7c82314..89e2ea6 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -275,6 +275,7 @@ USBDevice *usbdevice_create(const char *cmdline) len = sizeof(driver); pstrcpy(driver, len, cmdline); } else { + params = ""; pstrcpy(driver, sizeof(driver), cmdline); }