* [Qemu-devel] [PATCH] Avoid crash on '-usbdevice <device>' without parameters
@ 2010-03-07 10:48 Jan Kiszka
2010-03-07 11:17 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2010-03-07 10:48 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Many usbdevice_init implementors assume params is non-NULL.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
hw/usb-bus.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index 7c82314..89e2ea6 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -275,6 +275,7 @@ USBDevice *usbdevice_create(const char *cmdline)
len = sizeof(driver);
pstrcpy(driver, len, cmdline);
} else {
+ params = "";
pstrcpy(driver, sizeof(driver), cmdline);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] [PATCH v2] Avoid crash on '-usbdevice <device>' without parameters
2010-03-07 10:48 [Qemu-devel] [PATCH] Avoid crash on '-usbdevice <device>' without parameters Jan Kiszka
@ 2010-03-07 11:17 ` Jan Kiszka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2010-03-07 11:17 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Many usbdevice_init implementors assume params is non-NULL.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
Build fixed - sorry.
hw/usb-bus.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index 7c82314..3bb8986 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -264,7 +264,8 @@ USBDevice *usbdevice_create(const char *cmdline)
USBBus *bus = usb_bus_find(-1 /* any */);
DeviceInfo *info;
USBDeviceInfo *usb;
- char driver[32], *params;
+ char driver[32];
+ const char *params;
int len;
params = strchr(cmdline,':');
@@ -275,6 +276,7 @@ USBDevice *usbdevice_create(const char *cmdline)
len = sizeof(driver);
pstrcpy(driver, len, cmdline);
} else {
+ params = "";
pstrcpy(driver, sizeof(driver), cmdline);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-07 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-07 10:48 [Qemu-devel] [PATCH] Avoid crash on '-usbdevice <device>' without parameters Jan Kiszka
2010-03-07 11:17 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).