From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NogB0-0002iA-5s
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 11:51:30 -0500
Received: from [199.232.76.173] (port=35881 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NogAz-0002gn-KK
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 11:51:29 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Nog4S-0007lS-VJ
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 11:44:46 -0500
Received: from mail-ww0-f45.google.com ([74.125.82.45]:47730)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Nog4S-0007it-Mk
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 11:44:44 -0500
Received: by mail-ww0-f45.google.com with SMTP id 34so3152602wwb.4
	for <qemu-devel@nongnu.org>; Mon, 08 Mar 2010 08:44:44 -0800 (PST)
Message-ID: <4B952975.6000605@codemonkey.ws>
Date: Mon, 08 Mar 2010 10:44:37 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4B937FE0.5080609@siemens.com>
In-Reply-To: <4B937FE0.5080609@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RESEND][PATCH][STABLE] Fix corner case in chardev
	udp: parameter
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 03/07/2010 04:28 AM, Jan Kiszka wrote:
> The missing '@' broke 'udp::<port>@:<port>' parsing.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>    

Applied to stable, thanks.

Regards,

Anthony Liguori

> ---
>   qemu-char.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 86c7c5a..0d8553d 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2333,7 +2333,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
>           qemu_opt_set(opts, "backend", "udp");
>           if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)<  2) {
>               host[0] = 0;
> -            if (sscanf(p, ":%32[^,]%n", port,&pos)<  1) {
> +            if (sscanf(p, ":%32[^@,]%n", port,&pos)<  1) {
>                   goto fail;
>               }
>           }
>
>