From: Anthony Liguori <anthony@codemonkey.ws>
To: Chris Kilgour <techie@whiterocker.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry)
Date: Tue, 09 Mar 2010 08:24:21 -0600 [thread overview]
Message-ID: <4B965A15.9020809@codemonkey.ws> (raw)
In-Reply-To: <4B84C7EE.4050303@whiterocker.com>
On 02/24/2010 12:32 AM, Chris Kilgour wrote:
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
> Signed-off-by: Christopher Kilgour<techie@whiterocker.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 44b5b31..f889898 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
> printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
> #endif
> /* Check APROMWE bit to enable write access */
> - if (pcnet_bcr_readw(s,2)& 0x80)
> + if (pcnet_bcr_readw(s,2)& 0x100)
> s->prom[addr& 15] = val;
> }
>
>
>
>
>
prev parent reply other threads:[~2010-03-09 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 1:53 [Qemu-devel] [PATCH] pcnet APROMWE bit location Chris Kilgour
2010-02-19 21:33 ` Anthony Liguori
2010-02-24 6:32 ` [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry) Chris Kilgour
2010-03-09 14:24 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B965A15.9020809@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=techie@whiterocker.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).