From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np0Wt-0006pv-QD
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:35:28 -0500
Received: from [199.232.76.173] (port=44128 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np0Wq-0006oB-80
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:35:24 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np0MF-0006nn-KL
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:24:28 -0500
Received: from qw-out-1920.google.com ([74.125.92.148]:64589)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np0MF-0006nj-DX
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:24:27 -0500
Received: by qw-out-1920.google.com with SMTP id 5so1729441qwf.4
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 06:24:26 -0800 (PST)
Message-ID: <4B965A15.9020809@codemonkey.ws>
Date: Tue, 09 Mar 2010 08:24:21 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry)
References: <4B78A904.9020700@whiterocker.com> <4B7F0390.1030206@codemonkey.ws>
	<4B84C7EE.4050303@whiterocker.com>
In-Reply-To: <4B84C7EE.4050303@whiterocker.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chris Kilgour <techie@whiterocker.com>
Cc: qemu-devel@nongnu.org

On 02/24/2010 12:32 AM, Chris Kilgour wrote:
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
> Signed-off-by: Christopher Kilgour<techie@whiterocker.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 44b5b31..f889898 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
>       printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
>   #endif
>       /* Check APROMWE bit to enable write access */
> -    if (pcnet_bcr_readw(s,2)&  0x80)
> +    if (pcnet_bcr_readw(s,2)&  0x100)
>           s->prom[addr&  15] = val;
>   }
>
>
>
>
>