* [Qemu-devel] [PATCH] pcnet APROMWE bit location
@ 2010-02-15 1:53 Chris Kilgour
2010-02-19 21:33 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Chris Kilgour @ 2010-02-15 1:53 UTC (permalink / raw)
To: qemu-devel
I don't subscribe to the list, so please excuse any breach of etiquette.
According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
Signed-off-by: Christopher Kilgour <techie <at> whiterocker.com>
---
diff --git a/hw/pcnet.c b/hw/pcnet.c
index 44b5b31..f889898 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,
uint32_t addr
printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
#endif
/* Check APROMWE bit to enable write access */
- if (pcnet_bcr_readw(s,2) & 0x80)
+ if (pcnet_bcr_readw(s,2) & 0x100)
s->prom[addr & 15] = val;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location
2010-02-15 1:53 [Qemu-devel] [PATCH] pcnet APROMWE bit location Chris Kilgour
@ 2010-02-19 21:33 ` Anthony Liguori
2010-02-24 6:32 ` [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry) Chris Kilgour
0 siblings, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2010-02-19 21:33 UTC (permalink / raw)
To: Chris Kilgour; +Cc: qemu-devel
On 02/14/2010 07:53 PM, Chris Kilgour wrote:
> I don't subscribe to the list, so please excuse any breach of etiquette.
>
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
> Signed-off-by: Christopher Kilgour<techie<at> whiterocker.com>
>
Your mailer munged this patch so it doesn't apply. Please resend.
Also, please use a proper email address in the Signed-off-by line.
Regards,
Anthony Liguori
> ---
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 44b5b31..f889898 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,
> uint32_t addr
> printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
> #endif
> /* Check APROMWE bit to enable write access */
> - if (pcnet_bcr_readw(s,2)& 0x80)
> + if (pcnet_bcr_readw(s,2)& 0x100)
> s->prom[addr& 15] = val;
> }
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry)
2010-02-19 21:33 ` Anthony Liguori
@ 2010-02-24 6:32 ` Chris Kilgour
2010-03-09 14:24 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Chris Kilgour @ 2010-02-24 6:32 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
Signed-off-by: Christopher Kilgour <techie@whiterocker.com>
---
diff --git a/hw/pcnet.c b/hw/pcnet.c
index 44b5b31..f889898 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
#endif
/* Check APROMWE bit to enable write access */
- if (pcnet_bcr_readw(s,2) & 0x80)
+ if (pcnet_bcr_readw(s,2) & 0x100)
s->prom[addr & 15] = val;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry)
2010-02-24 6:32 ` [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry) Chris Kilgour
@ 2010-03-09 14:24 ` Anthony Liguori
0 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2010-03-09 14:24 UTC (permalink / raw)
To: Chris Kilgour; +Cc: qemu-devel
On 02/24/2010 12:32 AM, Chris Kilgour wrote:
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
> Signed-off-by: Christopher Kilgour<techie@whiterocker.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 44b5b31..f889898 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
> printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
> #endif
> /* Check APROMWE bit to enable write access */
> - if (pcnet_bcr_readw(s,2)& 0x80)
> + if (pcnet_bcr_readw(s,2)& 0x100)
> s->prom[addr& 15] = val;
> }
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-09 14:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-15 1:53 [Qemu-devel] [PATCH] pcnet APROMWE bit location Chris Kilgour
2010-02-19 21:33 ` Anthony Liguori
2010-02-24 6:32 ` [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry) Chris Kilgour
2010-03-09 14:24 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).