From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np0Wt-0006ph-BP
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:35:27 -0500
Received: from [199.232.76.173] (port=44126 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np0Wq-0006mN-1I
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:35:24 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <aliguori@redhat.com>) id 1Np0ML-0006oL-4V
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:24:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41303)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <aliguori@redhat.com>) id 1Np0MK-0006o4-Ob
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:24:33 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o29EOUYH023647
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Mar 2010 09:24:31 -0500
Message-ID: <4B965A1D.7030808@redhat.com>
Date: Tue, 09 Mar 2010 08:24:29 -0600
From: Anthony Liguori <aliguori@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] adding helper pci functions
References: <1267087285-15582-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1267087285-15582-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Izik Eidus <ieidus@redhat.com>, qemu-devel@nongnu.org

On 02/25/2010 02:41 AM, Gerd Hoffmann wrote:
> From: Izik Eidus<ieidus@redhat.com>
>
> Signed-off-by: Izik Eidus<ieidus@redhat.com>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   hw/pci.h |   18 ++++++++++++++++++
>   1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci.h b/hw/pci.h
> index 37ebdc4..20c670e 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -301,11 +301,29 @@ pci_config_set_device_id(uint8_t *pci_config, uint16_t val)
>   }
>
>   static inline void
> +pci_config_set_revision(uint8_t *pci_config, uint8_t val)
> +{
> +    pci_set_byte(&pci_config[PCI_REVISION_ID], val);
> +}
> +
> +static inline void
>   pci_config_set_class(uint8_t *pci_config, uint16_t val)
>   {
>       pci_set_word(&pci_config[PCI_CLASS_DEVICE], val);
>   }
>
> +static inline void
> +pci_config_set_prog_interface(uint8_t *pci_config, uint8_t val)
> +{
> +    pci_set_byte(&pci_config[PCI_CLASS_PROG], val);
> +}
> +
> +static inline void
> +pci_config_set_interrupt_pin(uint8_t *pci_config, uint8_t val)
> +{
> +    pci_set_byte(&pci_config[PCI_INTERRUPT_PIN], val);
> +}
> +
>   typedef int (*pci_qdev_initfn)(PCIDevice *dev);
>   typedef struct {
>       DeviceInfo qdev;
>