* [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
@ 2010-03-05 8:08 Paolo Bonzini
2010-03-06 22:10 ` Aurelien Jarno
2010-03-09 14:36 ` [Qemu-devel] " Anthony Liguori
0 siblings, 2 replies; 7+ messages in thread
From: Paolo Bonzini @ 2010-03-05 8:08 UTC (permalink / raw)
To: qemu-devel
The relative URLs do not work when cloning a fork of qemu or when
cloning from the Savannah URL.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
.gitmodules | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitmodules b/.gitmodules
index dd4745e..5217ce7 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
[submodule "roms/vgabios"]
path = roms/vgabios
- url = ../vgabios.git
+ url = git://git.qemu.org/vgabios.git/
[submodule "roms/seabios"]
path = roms/seabios
- url = ../seabios.git
+ url = git://git.qemu.org/seabios.git/
--
1.6.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-05 8:08 [Qemu-devel] [PATCH] use absolute URLs for .gitmodules Paolo Bonzini
@ 2010-03-06 22:10 ` Aurelien Jarno
2010-03-07 10:06 ` [Qemu-devel] " Paolo Bonzini
2010-03-09 14:36 ` [Qemu-devel] " Anthony Liguori
1 sibling, 1 reply; 7+ messages in thread
From: Aurelien Jarno @ 2010-03-06 22:10 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Fri, Mar 05, 2010 at 09:08:04AM +0100, Paolo Bonzini wrote:
> The relative URLs do not work when cloning a fork of qemu or when
> cloning from the Savannah URL.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitmodules | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index dd4745e..5217ce7 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,6 @@
> [submodule "roms/vgabios"]
> path = roms/vgabios
> - url = ../vgabios.git
> + url = git://git.qemu.org/vgabios.git/
> [submodule "roms/seabios"]
> path = roms/seabios
> - url = ../seabios.git
> + url = git://git.qemu.org/seabios.git/
Is the slash at the end of the URL really wanted?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-05 8:08 [Qemu-devel] [PATCH] use absolute URLs for .gitmodules Paolo Bonzini
2010-03-06 22:10 ` Aurelien Jarno
@ 2010-03-09 14:36 ` Anthony Liguori
1 sibling, 0 replies; 7+ messages in thread
From: Anthony Liguori @ 2010-03-09 14:36 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On 03/05/2010 02:08 AM, Paolo Bonzini wrote:
> The relative URLs do not work when cloning a fork of qemu or when
> cloning from the Savannah URL.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> .gitmodules | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index dd4745e..5217ce7 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,6 @@
> [submodule "roms/vgabios"]
> path = roms/vgabios
> - url = ../vgabios.git
> + url = git://git.qemu.org/vgabios.git/
> [submodule "roms/seabios"]
> path = roms/seabios
> - url = ../seabios.git
> + url = git://git.qemu.org/seabios.git/
>
Relative URLs are more friendly for users of proxies.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <947437890.3137451268151696623.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>]
* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
[not found] <947437890.3137451268151696623.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
@ 2010-03-09 16:38 ` Paolo Bonzini
2010-03-09 17:08 ` Anthony Liguori
0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2010-03-09 16:38 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
> > diff --git a/.gitmodules b/.gitmodules
> > index dd4745e..5217ce7 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -1,6 +1,6 @@
> > [submodule "roms/vgabios"]
> > path = roms/vgabios
> > - url = ../vgabios.git
> > + url = git://git.qemu.org/vgabios.git/
> > [submodule "roms/seabios"]
> > path = roms/seabios
> > - url = ../seabios.git
> > + url = git://git.qemu.org/seabios.git/
> >
>
> Relative URLs are more friendly for users of proxies.
Users of proxies can still customize their .git/config file. This
bug caused (or contributed to) a real problem in the qemu-kvm
releases (they do not include seabios/vgabios references).
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-09 16:38 ` Paolo Bonzini
@ 2010-03-09 17:08 ` Anthony Liguori
2010-03-09 17:34 ` Avi Kivity
0 siblings, 1 reply; 7+ messages in thread
From: Anthony Liguori @ 2010-03-09 17:08 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Avi Kivity
On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>> diff --git a/.gitmodules b/.gitmodules
>>> index dd4745e..5217ce7 100644
>>> --- a/.gitmodules
>>> +++ b/.gitmodules
>>> @@ -1,6 +1,6 @@
>>> [submodule "roms/vgabios"]
>>> path = roms/vgabios
>>> - url = ../vgabios.git
>>> + url = git://git.qemu.org/vgabios.git/
>>> [submodule "roms/seabios"]
>>> path = roms/seabios
>>> - url = ../seabios.git
>>> + url = git://git.qemu.org/seabios.git/
>>>
>>>
>> Relative URLs are more friendly for users of proxies.
>>
> Users of proxies can still customize their .git/config file. This
> bug caused (or contributed to) a real problem in the qemu-kvm
> releases (they do not include seabios/vgabios references).
>
That's odd because Avi's the one who has historically advocated relative
URLs.
Regards,
Anthony Liguori
> Paolo
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-09 17:08 ` Anthony Liguori
@ 2010-03-09 17:34 ` Avi Kivity
0 siblings, 0 replies; 7+ messages in thread
From: Avi Kivity @ 2010-03-09 17:34 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Paolo Bonzini, qemu-devel
On 03/09/2010 07:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>>> diff --git a/.gitmodules b/.gitmodules
>>>> index dd4745e..5217ce7 100644
>>>> --- a/.gitmodules
>>>> +++ b/.gitmodules
>>>> @@ -1,6 +1,6 @@
>>>> [submodule "roms/vgabios"]
>>>> path = roms/vgabios
>>>> - url = ../vgabios.git
>>>> + url = git://git.qemu.org/vgabios.git/
>>>> [submodule "roms/seabios"]
>>>> path = roms/seabios
>>>> - url = ../seabios.git
>>>> + url = git://git.qemu.org/seabios.git/
>>>>
>>> Relative URLs are more friendly for users of proxies.
>> Users of proxies can still customize their .git/config file. This
>> bug caused (or contributed to) a real problem in the qemu-kvm
>> releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated
> relative URLs.
I can fix the reference problem by adding something to a README. Using
an absolute URL means users behind firewalls cannot clone the submodules
anymore without tinkering with git config files.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-09 17:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-05 8:08 [Qemu-devel] [PATCH] use absolute URLs for .gitmodules Paolo Bonzini
2010-03-06 22:10 ` Aurelien Jarno
2010-03-07 10:06 ` [Qemu-devel] " Paolo Bonzini
2010-03-09 14:36 ` [Qemu-devel] " Anthony Liguori
[not found] <947437890.3137451268151696623.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2010-03-09 16:38 ` Paolo Bonzini
2010-03-09 17:08 ` Anthony Liguori
2010-03-09 17:34 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).