From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np0vx-00058l-8w
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:01:21 -0500
Received: from [199.232.76.173] (port=44776 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np0vw-00057s-NF
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:01:20 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np0vv-0001kF-8y
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:01:20 -0500
Received: from mail-ew0-f214.google.com ([209.85.219.214]:38107)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np0vv-0001k3-0A
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:01:19 -0500
Received: by ewy6 with SMTP id 6so4188733ewy.17
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 07:01:17 -0800 (PST)
Message-ID: <4B9662B8.5070605@codemonkey.ws>
Date: Tue, 09 Mar 2010 09:01:12 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] scsi: Make device scsi-disk reject /dev/sg*
References: <m3iq9lvcjr.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3iq9lvcjr.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 02/25/2010 04:23 AM, Markus Armbruster wrote:
> You're supposed to use scsi-generic for that.  Which rejects anything
> but /dev/sg*.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
> ---
>    

Applied.  Thanks.

Regards,

Anthony Liguori

>   hw/scsi-disk.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index b2f61fe..ad8eb24 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -1027,6 +1027,11 @@ static int scsi_disk_initfn(SCSIDevice *dev)
>       }
>       s->bs = s->qdev.conf.dinfo->bdrv;
>
> +    if (bdrv_is_sg(s->bs)) {
> +        qemu_error("scsi-disk: unwanted /dev/sg*\n");
> +        return -1;
> +    }
> +
>       if (bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM) {
>           s->cluster_size = 4;
>       } else {
>