From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np0wt-0006SB-Md
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:02:19 -0500
Received: from [199.232.76.173] (port=44799 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np0wt-0006RV-4t
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:02:19 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np0wr-0001ph-8p
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:02:18 -0500
Received: from mail-ew0-f214.google.com ([209.85.219.214]:60151)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np0wq-0001mU-NZ
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:02:17 -0500
Received: by mail-ew0-f214.google.com with SMTP id 6so4189242ewy.17
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 07:02:16 -0800 (PST)
Message-ID: <4B9662F2.3080208@codemonkey.ws>
Date: Tue, 09 Mar 2010 09:02:10 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based
	monitor
References: <20100226093456.GA17347@redhat.com>
In-Reply-To: <20100226093456.GA17347@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shahar Havivi <shaharh@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, qemu-devel@nongnu.org

On 02/26/2010 03:34 AM, Shahar Havivi wrote:
> Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle
> close when using tty devices (like /dev/ttyS0),
> yet tty based monitor are not restoring terminal attributes (as done
> with stdio based monitor), when closing qemu after that command:
> $ qemu -monitor /dev/tty
> the terminal is not responding until you write reset (blindly),
> this patch fix it
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   qemu-char.c |    8 ++++++++
>   1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 4169492..7aae21b 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed,
>              speed, parity, data_bits, stop_bits);
>   #endif
>       tcgetattr (fd,&tty);
> +    oldtty = tty;
>
>   #define check_speed(val) if (speed<= val) { spd = B##val; break; }
>       speed = speed * 10 / 11;
> @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
>       return 0;
>   }
>
> +static void tty_exit(void)
> +{
> +    tcsetattr(0, TCSANOW,&oldtty);
> +}
> +
>   static void qemu_chr_close_tty(CharDriverState *chr)
>   {
>       FDCharDriver *s = chr->opaque;
> @@ -1207,6 +1213,8 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>       }
>       chr->chr_ioctl = tty_serial_ioctl;
>       chr->chr_close = qemu_chr_close_tty;
> +    if (!term_atexit_done++)
> +        atexit(tty_exit);
>       return chr;
>   }
>   #else  /* ! __linux__&&  ! __sun__ */
> --
> 1.6.3.3
>
>
>
>
>