From: Anthony Liguori <anthony@codemonkey.ws>
To: Roy Tam <roytam@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Serial: DOS Plus regression
Date: Tue, 09 Mar 2010 09:05:28 -0600 [thread overview]
Message-ID: <4B9663B8.8070507@codemonkey.ws> (raw)
In-Reply-To: <473191351002280003y34b9f473m27db1fea2cec1bb8@mail.gmail.com>
On 02/28/2010 02:03 AM, Roy Tam wrote:
> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
> booting Digital Research DOSPlus. Following patch partially reverts
> that commit and makes DOSPlus booting in QEMU again.
>
> Sign-off-by: Roy Tam<roytam@gmail.com>
>
> --
>
> diff --git a/hw/serial.c b/hw/serial.c
> index df67383..cf23aad 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
> uint32_t addr, uint32_t val)
>
This patch is whitespace damaged.
Regards,
Anthony Liguori
> s->poll_msl = 0;
> }
> }
> - if (s->lsr& UART_LSR_THRE) {
> - s->thr_ipending = 1;
> - serial_update_irq(s);
> - }
> }
> break;
> case 2:
>
>
>
>
next prev parent reply other threads:[~2010-03-09 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 8:03 [Qemu-devel] [PATCH] Serial: DOS Plus regression Roy Tam
2010-03-09 15:05 ` Anthony Liguori [this message]
2010-03-09 15:39 ` Roy Tam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9663B8.8070507@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=roytam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).