From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np105-0001Uv-7V
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:05:37 -0500
Received: from [199.232.76.173] (port=54952 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np103-0001Te-T0
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:05:36 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np102-000266-GR
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:05:35 -0500
Received: from mail-ew0-f214.google.com ([209.85.219.214]:57130)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np102-00025u-6H
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 10:05:34 -0500
Received: by ewy6 with SMTP id 6so4192492ewy.17
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 07:05:33 -0800 (PST)
Message-ID: <4B9663B8.8070507@codemonkey.ws>
Date: Tue, 09 Mar 2010 09:05:28 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Serial: DOS Plus regression
References: <473191351002280003y34b9f473m27db1fea2cec1bb8@mail.gmail.com>
In-Reply-To: <473191351002280003y34b9f473m27db1fea2cec1bb8@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Tam <roytam@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 02/28/2010 02:03 AM, Roy Tam wrote:
> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
> booting Digital Research DOSPlus. Following patch partially reverts
> that commit and makes DOSPlus booting in QEMU again.
>
> Sign-off-by: Roy Tam<roytam@gmail.com>
>
> --
>
> diff --git a/hw/serial.c b/hw/serial.c
> index df67383..cf23aad 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
> uint32_t addr, uint32_t val)
>    

This patch is whitespace damaged.

Regards,

Anthony Liguori

>                        s->poll_msl = 0;
>                   }
>               }
> -            if (s->lsr&  UART_LSR_THRE) {
> -                s->thr_ipending = 1;
> -                serial_update_irq(s);
> -            }
>           }
>           break;
>       case 2:
>
>
>
>