From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np20J-0006hh-V7
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:09:56 -0500
Received: from [199.232.76.173] (port=37394 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np20J-0006gY-9C
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:09:55 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np20I-0006hI-36
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:09:55 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:50759)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np20H-0006hE-SG
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:09:53 -0500
Received: by qw-out-1920.google.com with SMTP id 5so1774562qwf.4
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 08:09:53 -0800 (PST)
Message-ID: <4B9672CE.7000300@codemonkey.ws>
Date: Tue, 09 Mar 2010 10:09:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure
References: <1267201059-24145-1-git-send-email-kraxel@redhat.com>
	<1267201059-24145-2-git-send-email-kraxel@redhat.com>
	<4B96631E.4020700@codemonkey.ws>
	<201003091558.24975.paul@codesourcery.com>
In-Reply-To: <201003091558.24975.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 03/09/2010 09:58 AM, Paul Brook wrote:
>> On 02/26/2010 10:17 AM, Gerd Hoffmann wrote:
>>      
>>> Adds infrastructure for keyboard led status tracking to qemu.
>>>
>>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>>>        
>> Applied.  Thanks.
>>      
> What about guests that use the capslock LED for something useful, instead of
> capslock?
>    

For VNC, tracking modifier state is already a heuristic so this series 
just adjusts that heuristic in a way that is better for 99% of use-cases.

I agree that we have to be careful about how we use information like 
this particularly when it comes to issues of correctness, but I don't 
believe this is such an instance.


Regards,

Anthony Liguori

> Paul
>