qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure
Date: Tue, 09 Mar 2010 10:28:11 -0600	[thread overview]
Message-ID: <4B96771B.5020509@codemonkey.ws> (raw)
In-Reply-To: <4B9673A3.9070601@redhat.com>

On 03/09/2010 10:13 AM, Gerd Hoffmann wrote:
> On 03/09/10 16:58, Paul Brook wrote:
>>> On 02/26/2010 10:17 AM, Gerd Hoffmann wrote:
>>>> Adds infrastructure for keyboard led status tracking to qemu.
>>>>
>>>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>>>
>>> Applied.  Thanks.
>>
>> What about guests that use the capslock LED for something useful, 
>> instead of
>> capslock?
>
> I offered write add a patch with a option to this off if you think it 
> is not needed.  Never got an answer, so I didn't.  Patch is on the 
> list now.

If a person has a guest that twiddles with LEDs, what are the chances 
they are going to figure out that there's an option with VNC to not use 
LED status as part of the modifier tracking heuristics?

I don't think it's really useful.  Like I said in an earlier note, we're 
already dealing with a heuristics based algorithm because we're 
attempting to detect dangling modifier presses.  I'd rather see an 
option that disabled the whole thing verses something specific to the LEDs.

Regards,

Anthony Liguori

> cheers,
>   Gerd

  reply	other threads:[~2010-03-09 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26 16:17 [Qemu-devel] [PATCH v2 0/4] keyboard led status tracking Gerd Hoffmann
2010-02-26 16:17 ` [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure Gerd Hoffmann
2010-03-09 15:02   ` Anthony Liguori
2010-03-09 15:58     ` Paul Brook
2010-03-09 16:09       ` Anthony Liguori
2010-03-09 16:13       ` Gerd Hoffmann
2010-03-09 16:28         ` Anthony Liguori [this message]
2010-03-09 16:41           ` Gerd Hoffmann
2010-03-09 17:10             ` Anthony Liguori
2010-02-26 16:17 ` [Qemu-devel] [PATCH v2 2/4] kbd leds: ps/2 kbd Gerd Hoffmann
2010-02-26 16:17 ` [Qemu-devel] [PATCH v2 3/4] kbd leds: usb kbd Gerd Hoffmann
2010-02-26 16:17 ` [Qemu-devel] [PATCH v2 4/4] kbd keds: vnc Gerd Hoffmann
2010-02-26 17:29 ` [Qemu-devel] Re: [PATCH v2 0/4] keyboard led status tracking Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B96771B.5020509@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=kraxel@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).