From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np2I9-000449-UO
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:28:22 -0500
Received: from [199.232.76.173] (port=54747 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np2I8-00043B-Ka
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:28:20 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np2I7-0008EF-4q
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:28:20 -0500
Received: from mail-ew0-f214.google.com ([209.85.219.214]:51859)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np2I6-0008Dx-Qa
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:28:19 -0500
Received: by ewy6 with SMTP id 6so4259132ewy.17
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 08:28:17 -0800 (PST)
Message-ID: <4B96771B.5020509@codemonkey.ws>
Date: Tue, 09 Mar 2010 10:28:11 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure
References: <1267201059-24145-1-git-send-email-kraxel@redhat.com>
	<1267201059-24145-2-git-send-email-kraxel@redhat.com>
	<4B96631E.4020700@codemonkey.ws>
	<201003091558.24975.paul@codesourcery.com>
	<4B9673A3.9070601@redhat.com>
In-Reply-To: <4B9673A3.9070601@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

On 03/09/2010 10:13 AM, Gerd Hoffmann wrote:
> On 03/09/10 16:58, Paul Brook wrote:
>>> On 02/26/2010 10:17 AM, Gerd Hoffmann wrote:
>>>> Adds infrastructure for keyboard led status tracking to qemu.
>>>>
>>>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>>>
>>> Applied.  Thanks.
>>
>> What about guests that use the capslock LED for something useful, 
>> instead of
>> capslock?
>
> I offered write add a patch with a option to this off if you think it 
> is not needed.  Never got an answer, so I didn't.  Patch is on the 
> list now.

If a person has a guest that twiddles with LEDs, what are the chances 
they are going to figure out that there's an option with VNC to not use 
LED status as part of the modifier tracking heuristics?

I don't think it's really useful.  Like I said in an earlier note, we're 
already dealing with a heuristics based algorithm because we're 
attempting to detect dangling modifier presses.  I'd rather see an 
option that disabled the whole thing verses something specific to the LEDs.

Regards,

Anthony Liguori

> cheers,
>   Gerd