From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np2VW-0000MN-GS
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:42:10 -0500
Received: from [199.232.76.173] (port=35668 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np2VV-0000Le-VT
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:42:10 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1Np2VV-0001L9-7s
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:42:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39011)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Np2VU-0001L3-TL
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:42:09 -0500
Message-ID: <4B967A48.5030005@redhat.com>
Date: Tue, 09 Mar 2010 17:41:44 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure
References: <1267201059-24145-1-git-send-email-kraxel@redhat.com>
	<1267201059-24145-2-git-send-email-kraxel@redhat.com>
	<4B96631E.4020700@codemonkey.ws>
	<201003091558.24975.paul@codesourcery.com>
	<4B9673A3.9070601@redhat.com> <4B96771B.5020509@codemonkey.ws>
In-Reply-To: <4B96771B.5020509@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

On 03/09/10 17:28, Anthony Liguori wrote:
> If a person has a guest that twiddles with LEDs, what are the chances
> they are going to figure out that there's an option with VNC to not use
> LED status as part of the modifier tracking heuristics?
>
> I don't think it's really useful. Like I said in an earlier note, we're
> already dealing with a heuristics based algorithm because we're
> attempting to detect dangling modifier presses. I'd rather see an option
> that disabled the whole thing verses something specific to the LEDs.

You are referring to the 
do-i-should-insert-extra-capslock/numlock-events logic in do_key_event() 
?  Well, we can turn off both, fine with me, after all they sort-of 
belong together.  Do you have an idea for a short 
'no-capslock-and-numlock-tracking-heuristics' option name?

cheers,
   Gerd