From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np382-0002am-N2
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:21:58 -0500
Received: from [199.232.76.173] (port=41408 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np381-0002Zn-UH
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:21:57 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Np380-0005x5-Lw
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:21:57 -0500
Received: from mail-pv0-f173.google.com ([74.125.83.173]:34424)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Np380-0005wy-CQ
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:21:56 -0500
Received: by pvg12 with SMTP id 12so2103989pvg.4
	for <qemu-devel@nongnu.org>; Tue, 09 Mar 2010 09:21:54 -0800 (PST)
Message-ID: <4B9683AF.5030208@codemonkey.ws>
Date: Tue, 09 Mar 2010 11:21:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] configure: Fix code which creates config.mak
	files
References: <1267478429-6412-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1267478429-6412-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 03/01/2010 03:20 PM, Stefan Weil wrote:
> These files are created by configure and grow
> unnecessarily at each new call of configure:
>
> roms/seabios/config.mak
> roms/vgabios/config.mak
> libhw32/config.mak
> libhw64/config.mak
>
> libhw32/config.mak and libhw64/config.mak set
> compiler options, and the wrong old code results
> in very long command lines.
>
> The new code always writes a new config.mak
> instead of appending to an existing one.
>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>    


Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   configure |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index a14aba7..b4db650 100755
> --- a/configure
> +++ b/configure
> @@ -2723,7 +2723,7 @@ fi
>   # temporary config to build submodules
>   for rom in seabios vgabios ; do
>       config_mak=roms/$rom/config.mak
> -    echo "# Automatically generated by configure - do not modify">>  $config_mak
> +    echo "# Automatically generated by configure - do not modify">  $config_mak
>       echo "SRC_PATH=$source_path/roms/$rom">>  $config_mak
>       echo "CC=$cc">>  $config_mak
>       echo "BCC=bcc">>  $config_mak
> @@ -2739,7 +2739,7 @@ for hwlib in 32 64; do
>     mkdir -p $d
>     rm -f $d/Makefile
>     ln -s $source_path/Makefile.hw $d/Makefile
> -  echo "QEMU_CFLAGS+=-DTARGET_PHYS_ADDR_BITS=$hwlib">>  $d/config.mak
> +  echo "QEMU_CFLAGS+=-DTARGET_PHYS_ADDR_BITS=$hwlib">  $d/config.mak
>   done
>
>   d=libuser
>