From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np3KJ-0001fv-9f
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:34:39 -0500
Received: from [199.232.76.173] (port=49660 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np3KI-0001ek-J5
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:34:38 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <avi@redhat.com>) id 1Np3KH-0007IG-FS
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:34:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21818)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Np3KH-0007IA-3I
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 12:34:37 -0500
Message-ID: <4B9686A7.1040501@redhat.com>
Date: Tue, 09 Mar 2010 19:34:31 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
References: <290818601.3139451268152701383.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
	<4B968097.7090305@codemonkey.ws>
In-Reply-To: <4B968097.7090305@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 03/09/2010 07:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>>> diff --git a/.gitmodules b/.gitmodules
>>>> index dd4745e..5217ce7 100644
>>>> --- a/.gitmodules
>>>> +++ b/.gitmodules
>>>> @@ -1,6 +1,6 @@
>>>>    [submodule "roms/vgabios"]
>>>>        path = roms/vgabios
>>>> -    url = ../vgabios.git
>>>> +    url = git://git.qemu.org/vgabios.git/
>>>>    [submodule "roms/seabios"]
>>>>        path = roms/seabios
>>>> -    url = ../seabios.git
>>>> +    url = git://git.qemu.org/seabios.git/
>>>>
>>> Relative URLs are more friendly for users of proxies.
>> Users of proxies can still customize their .git/config file.  This
>> bug caused (or contributed to) a real problem in the qemu-kvm
>> releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated 
> relative URLs.

I can fix the reference problem by adding something to a README.  Using 
an absolute URL means users behind firewalls cannot clone the submodules 
anymore without tinkering with git config files.

-- 
error compiling committee.c: too many arguments to function