From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NpIxV-000068-9J for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:16:09 -0500 Received: from [199.232.76.173] (port=39823 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NpIxT-00005U-N7 for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:16:08 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NpIxS-0002s1-HU for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:16:07 -0500 Received: from mail-qy0-f190.google.com ([209.85.221.190]:46611) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NpIxS-0002rr-8z for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:16:06 -0500 Received: by qyk28 with SMTP id 28so9418763qyk.14 for ; Wed, 10 Mar 2010 02:16:05 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4B97715F.2040403@redhat.com> Date: Wed, 10 Mar 2010 11:15:59 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <290818601.3139451268152701383.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> <4B968097.7090305@codemonkey.ws> In-Reply-To: <4B968097.7090305@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Avi Kivity On 03/09/2010 06:08 PM, Anthony Liguori wrote: > On 03/09/2010 10:38 AM, Paolo Bonzini wrote: >>>> diff --git a/.gitmodules b/.gitmodules >>>> index dd4745e..5217ce7 100644 >>>> --- a/.gitmodules >>>> +++ b/.gitmodules >>>> @@ -1,6 +1,6 @@ >>>> [submodule "roms/vgabios"] >>>> path = roms/vgabios >>>> - url = ../vgabios.git >>>> + url = git://git.qemu.org/vgabios.git/ >>>> [submodule "roms/seabios"] >>>> path = roms/seabios >>>> - url = ../seabios.git >>>> + url = git://git.qemu.org/seabios.git/ >>>> >>> Relative URLs are more friendly for users of proxies. >> Users of proxies can still customize their .git/config file. This >> bug caused (or contributed to) a real problem in the qemu-kvm >> releases (they do not include seabios/vgabios references). > > That's odd because Avi's the one who has historically advocated relative > URLs. If we also get rid of the savannah git repo, or plan to do so, I have no issue with reverting this patch. Paolo