* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
[not found] <947437890.3137451268151696623.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
@ 2010-03-09 16:38 ` Paolo Bonzini
2010-03-09 17:08 ` Anthony Liguori
0 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2010-03-09 16:38 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
> > diff --git a/.gitmodules b/.gitmodules
> > index dd4745e..5217ce7 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -1,6 +1,6 @@
> > [submodule "roms/vgabios"]
> > path = roms/vgabios
> > - url = ../vgabios.git
> > + url = git://git.qemu.org/vgabios.git/
> > [submodule "roms/seabios"]
> > path = roms/seabios
> > - url = ../seabios.git
> > + url = git://git.qemu.org/seabios.git/
> >
>
> Relative URLs are more friendly for users of proxies.
Users of proxies can still customize their .git/config file. This
bug caused (or contributed to) a real problem in the qemu-kvm
releases (they do not include seabios/vgabios references).
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-09 16:38 ` [Qemu-devel] [PATCH] use absolute URLs for .gitmodules Paolo Bonzini
@ 2010-03-09 17:08 ` Anthony Liguori
2010-03-09 17:34 ` Avi Kivity
2010-03-10 10:15 ` [Qemu-devel] " Paolo Bonzini
0 siblings, 2 replies; 9+ messages in thread
From: Anthony Liguori @ 2010-03-09 17:08 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Avi Kivity
On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>> diff --git a/.gitmodules b/.gitmodules
>>> index dd4745e..5217ce7 100644
>>> --- a/.gitmodules
>>> +++ b/.gitmodules
>>> @@ -1,6 +1,6 @@
>>> [submodule "roms/vgabios"]
>>> path = roms/vgabios
>>> - url = ../vgabios.git
>>> + url = git://git.qemu.org/vgabios.git/
>>> [submodule "roms/seabios"]
>>> path = roms/seabios
>>> - url = ../seabios.git
>>> + url = git://git.qemu.org/seabios.git/
>>>
>>>
>> Relative URLs are more friendly for users of proxies.
>>
> Users of proxies can still customize their .git/config file. This
> bug caused (or contributed to) a real problem in the qemu-kvm
> releases (they do not include seabios/vgabios references).
>
That's odd because Avi's the one who has historically advocated relative
URLs.
Regards,
Anthony Liguori
> Paolo
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-09 17:08 ` Anthony Liguori
@ 2010-03-09 17:34 ` Avi Kivity
2010-03-10 10:15 ` [Qemu-devel] " Paolo Bonzini
1 sibling, 0 replies; 9+ messages in thread
From: Avi Kivity @ 2010-03-09 17:34 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Paolo Bonzini, qemu-devel
On 03/09/2010 07:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>>> diff --git a/.gitmodules b/.gitmodules
>>>> index dd4745e..5217ce7 100644
>>>> --- a/.gitmodules
>>>> +++ b/.gitmodules
>>>> @@ -1,6 +1,6 @@
>>>> [submodule "roms/vgabios"]
>>>> path = roms/vgabios
>>>> - url = ../vgabios.git
>>>> + url = git://git.qemu.org/vgabios.git/
>>>> [submodule "roms/seabios"]
>>>> path = roms/seabios
>>>> - url = ../seabios.git
>>>> + url = git://git.qemu.org/seabios.git/
>>>>
>>> Relative URLs are more friendly for users of proxies.
>> Users of proxies can still customize their .git/config file. This
>> bug caused (or contributed to) a real problem in the qemu-kvm
>> releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated
> relative URLs.
I can fix the reference problem by adding something to a README. Using
an absolute URL means users behind firewalls cannot clone the submodules
anymore without tinkering with git config files.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules
2010-03-09 17:08 ` Anthony Liguori
2010-03-09 17:34 ` Avi Kivity
@ 2010-03-10 10:15 ` Paolo Bonzini
2010-03-10 14:21 ` Anthony Liguori
1 sibling, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2010-03-10 10:15 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Avi Kivity
On 03/09/2010 06:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>>> diff --git a/.gitmodules b/.gitmodules
>>>> index dd4745e..5217ce7 100644
>>>> --- a/.gitmodules
>>>> +++ b/.gitmodules
>>>> @@ -1,6 +1,6 @@
>>>> [submodule "roms/vgabios"]
>>>> path = roms/vgabios
>>>> - url = ../vgabios.git
>>>> + url = git://git.qemu.org/vgabios.git/
>>>> [submodule "roms/seabios"]
>>>> path = roms/seabios
>>>> - url = ../seabios.git
>>>> + url = git://git.qemu.org/seabios.git/
>>>>
>>> Relative URLs are more friendly for users of proxies.
>> Users of proxies can still customize their .git/config file. This
>> bug caused (or contributed to) a real problem in the qemu-kvm
>> releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated relative
> URLs.
If we also get rid of the savannah git repo, or plan to do so, I have no
issue with reverting this patch.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules
2010-03-10 10:15 ` [Qemu-devel] " Paolo Bonzini
@ 2010-03-10 14:21 ` Anthony Liguori
2010-03-10 14:44 ` Avi Kivity
2010-03-10 15:18 ` Paolo Bonzini
0 siblings, 2 replies; 9+ messages in thread
From: Anthony Liguori @ 2010-03-10 14:21 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Avi Kivity
On 03/10/2010 04:15 AM, Paolo Bonzini wrote:
> If we also get rid of the savannah git repo, or plan to do so, I have
> no issue with reverting this patch.
If someone can suggest a solution for mailing list hosting, I'd be happy
to leave Savannah tomorrow.
I'm not overly eager to do a mailing list migration though so if we do
the migration, we ought to ensure that we only have to do it once.
Savannah requires you to keep the main source repo on Savannah. We're
currently mirroring the git tree on git.qemu.org so it is possible to
clone directly from there.
Regards,
Anthony Liguori
> Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules
2010-03-10 14:21 ` Anthony Liguori
@ 2010-03-10 14:44 ` Avi Kivity
2010-03-10 14:55 ` Anthony Liguori
2010-03-10 15:18 ` Paolo Bonzini
1 sibling, 1 reply; 9+ messages in thread
From: Avi Kivity @ 2010-03-10 14:44 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Paolo Bonzini, qemu-devel
On 03/10/2010 04:21 PM, Anthony Liguori wrote:
> On 03/10/2010 04:15 AM, Paolo Bonzini wrote:
>> If we also get rid of the savannah git repo, or plan to do so, I have
>> no issue with reverting this patch.
>
> If someone can suggest a solution for mailing list hosting, I'd be
> happy to leave Savannah tomorrow.
vger.kernel.org has been hassle free since we moved to it.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules
2010-03-10 14:44 ` Avi Kivity
@ 2010-03-10 14:55 ` Anthony Liguori
0 siblings, 0 replies; 9+ messages in thread
From: Anthony Liguori @ 2010-03-10 14:55 UTC (permalink / raw)
To: Avi Kivity; +Cc: Paolo Bonzini, qemu-devel, Paul Brook
On 03/10/2010 08:44 AM, Avi Kivity wrote:
> On 03/10/2010 04:21 PM, Anthony Liguori wrote:
>> On 03/10/2010 04:15 AM, Paolo Bonzini wrote:
>>> If we also get rid of the savannah git repo, or plan to do so, I
>>> have no issue with reverting this patch.
>>
>> If someone can suggest a solution for mailing list hosting, I'd be
>> happy to leave Savannah tomorrow.
>
> vger.kernel.org has been hassle free since we moved to it.
Does anyone object to moving the mailing lists to vger.kernel.org?
We would then start pushing directly to git.qemu.org.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules
2010-03-10 14:21 ` Anthony Liguori
2010-03-10 14:44 ` Avi Kivity
@ 2010-03-10 15:18 ` Paolo Bonzini
1 sibling, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2010-03-10 15:18 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Avi Kivity
On 03/10/2010 03:21 PM, Anthony Liguori wrote:
>
>> If we also get rid of the savannah git repo, or plan to do so, I have
>> no issue with reverting this patch.
>
> If someone can suggest a solution for mailing list hosting, I'd be happy
> to leave Savannah tomorrow.
There is still the problem that
"git.savannah.nongnu.org" qemu -site:savannah.nongnu.org
returns 6 times more hits than
"git.qemu.org" -site:qemu.org
On one hand, this would be in favor of keeping my patch (savannah users
cannot get submodules correctly); on the other hand, it means that
leaving Savannah is not so easy.
If you prefer that, go ahead and revert it.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
@ 2010-03-05 8:08 Paolo Bonzini
2010-03-06 22:10 ` Aurelien Jarno
0 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2010-03-05 8:08 UTC (permalink / raw)
To: qemu-devel
The relative URLs do not work when cloning a fork of qemu or when
cloning from the Savannah URL.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
.gitmodules | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitmodules b/.gitmodules
index dd4745e..5217ce7 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
[submodule "roms/vgabios"]
path = roms/vgabios
- url = ../vgabios.git
+ url = git://git.qemu.org/vgabios.git/
[submodule "roms/seabios"]
path = roms/seabios
- url = ../seabios.git
+ url = git://git.qemu.org/seabios.git/
--
1.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
2010-03-05 8:08 [Qemu-devel] " Paolo Bonzini
@ 2010-03-06 22:10 ` Aurelien Jarno
2010-03-07 10:06 ` [Qemu-devel] " Paolo Bonzini
0 siblings, 1 reply; 9+ messages in thread
From: Aurelien Jarno @ 2010-03-06 22:10 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Fri, Mar 05, 2010 at 09:08:04AM +0100, Paolo Bonzini wrote:
> The relative URLs do not work when cloning a fork of qemu or when
> cloning from the Savannah URL.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitmodules | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index dd4745e..5217ce7 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,6 @@
> [submodule "roms/vgabios"]
> path = roms/vgabios
> - url = ../vgabios.git
> + url = git://git.qemu.org/vgabios.git/
> [submodule "roms/seabios"]
> path = roms/seabios
> - url = ../seabios.git
> + url = git://git.qemu.org/seabios.git/
Is the slash at the end of the URL really wanted?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-03-10 15:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <947437890.3137451268151696623.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2010-03-09 16:38 ` [Qemu-devel] [PATCH] use absolute URLs for .gitmodules Paolo Bonzini
2010-03-09 17:08 ` Anthony Liguori
2010-03-09 17:34 ` Avi Kivity
2010-03-10 10:15 ` [Qemu-devel] " Paolo Bonzini
2010-03-10 14:21 ` Anthony Liguori
2010-03-10 14:44 ` Avi Kivity
2010-03-10 14:55 ` Anthony Liguori
2010-03-10 15:18 ` Paolo Bonzini
2010-03-05 8:08 [Qemu-devel] " Paolo Bonzini
2010-03-06 22:10 ` Aurelien Jarno
2010-03-07 10:06 ` [Qemu-devel] " Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).