[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Paolo Bonzini]

On 03/06/2010 11:10 PM, Aurelien Jarno wrote:
> Is the slash at the end of the URL really wanted?

It works either with or without.

Paolo

Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules

[Paolo Bonzini]

> > diff --git a/.gitmodules b/.gitmodules
> > index dd4745e..5217ce7 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -1,6 +1,6 @@
> >   [submodule "roms/vgabios"]
> >   	path = roms/vgabios
> > -	url = ../vgabios.git
> > +	url = git://git.qemu.org/vgabios.git/
> >   [submodule "roms/seabios"]
> >   	path = roms/seabios
> > -	url = ../seabios.git
> > +	url = git://git.qemu.org/seabios.git/
> >    
> 
> Relative URLs are more friendly for users of proxies.

Users of proxies can still customize their .git/config file.  This
bug caused (or contributed to) a real problem in the qemu-kvm
releases (they do not include seabios/vgabios references).

Paolo

Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules

[Anthony Liguori]

On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>> diff --git a/.gitmodules b/.gitmodules
>>> index dd4745e..5217ce7 100644
>>> --- a/.gitmodules
>>> +++ b/.gitmodules
>>> @@ -1,6 +1,6 @@
>>>    [submodule "roms/vgabios"]
>>>    	path = roms/vgabios
>>> -	url = ../vgabios.git
>>> +	url = git://git.qemu.org/vgabios.git/
>>>    [submodule "roms/seabios"]
>>>    	path = roms/seabios
>>> -	url = ../seabios.git
>>> +	url = git://git.qemu.org/seabios.git/
>>>
>>>        
>> Relative URLs are more friendly for users of proxies.
>>      
> Users of proxies can still customize their .git/config file.  This
> bug caused (or contributed to) a real problem in the qemu-kvm
> releases (they do not include seabios/vgabios references).
>    

That's odd because Avi's the one who has historically advocated relative 
URLs.

Regards,

Anthony Liguori

> Paolo
>    

Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules

[Avi Kivity]

On 03/09/2010 07:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>>> diff --git a/.gitmodules b/.gitmodules
>>>> index dd4745e..5217ce7 100644
>>>> --- a/.gitmodules
>>>> +++ b/.gitmodules
>>>> @@ -1,6 +1,6 @@
>>>>    [submodule "roms/vgabios"]
>>>>        path = roms/vgabios
>>>> -    url = ../vgabios.git
>>>> +    url = git://git.qemu.org/vgabios.git/
>>>>    [submodule "roms/seabios"]
>>>>        path = roms/seabios
>>>> -    url = ../seabios.git
>>>> +    url = git://git.qemu.org/seabios.git/
>>>>
>>> Relative URLs are more friendly for users of proxies.
>> Users of proxies can still customize their .git/config file.  This
>> bug caused (or contributed to) a real problem in the qemu-kvm
>> releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated 
> relative URLs.

I can fix the reference problem by adding something to a README.  Using 
an absolute URL means users behind firewalls cannot clone the submodules 
anymore without tinkering with git config files.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Paolo Bonzini]

On 03/09/2010 06:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
>>>> diff --git a/.gitmodules b/.gitmodules
>>>> index dd4745e..5217ce7 100644
>>>> --- a/.gitmodules
>>>> +++ b/.gitmodules
>>>> @@ -1,6 +1,6 @@
>>>> [submodule "roms/vgabios"]
>>>> path = roms/vgabios
>>>> - url = ../vgabios.git
>>>> + url = git://git.qemu.org/vgabios.git/
>>>> [submodule "roms/seabios"]
>>>> path = roms/seabios
>>>> - url = ../seabios.git
>>>> + url = git://git.qemu.org/seabios.git/
>>>>
>>> Relative URLs are more friendly for users of proxies.
>> Users of proxies can still customize their .git/config file. This
>> bug caused (or contributed to) a real problem in the qemu-kvm
>> releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated relative
> URLs.

If we also get rid of the savannah git repo, or plan to do so, I have no 
issue with reverting this patch.

Paolo

[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Anthony Liguori]

On 03/10/2010 04:15 AM, Paolo Bonzini wrote:
> If we also get rid of the savannah git repo, or plan to do so, I have 
> no issue with reverting this patch.

If someone can suggest a solution for mailing list hosting, I'd be happy 
to leave Savannah tomorrow.

I'm not overly eager to do a mailing list migration though so if we do 
the migration, we ought to ensure that we only have to do it once.

Savannah requires you to keep the main source repo on Savannah.  We're 
currently mirroring the git tree on git.qemu.org so it is possible to 
clone directly from there.

Regards,

Anthony Liguori

> Paolo

[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Avi Kivity]

On 03/10/2010 04:21 PM, Anthony Liguori wrote:
> On 03/10/2010 04:15 AM, Paolo Bonzini wrote:
>> If we also get rid of the savannah git repo, or plan to do so, I have 
>> no issue with reverting this patch.
>
> If someone can suggest a solution for mailing list hosting, I'd be 
> happy to leave Savannah tomorrow.

vger.kernel.org has been hassle free since we moved to it.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Anthony Liguori]

On 03/10/2010 08:44 AM, Avi Kivity wrote:
> On 03/10/2010 04:21 PM, Anthony Liguori wrote:
>> On 03/10/2010 04:15 AM, Paolo Bonzini wrote:
>>> If we also get rid of the savannah git repo, or plan to do so, I 
>>> have no issue with reverting this patch.
>>
>> If someone can suggest a solution for mailing list hosting, I'd be 
>> happy to leave Savannah tomorrow.
>
> vger.kernel.org has been hassle free since we moved to it.

Does anyone object to moving the mailing lists to vger.kernel.org?

We would then start pushing directly to git.qemu.org.

Regards,

Anthony Liguori

[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

[Paolo Bonzini]

On 03/10/2010 03:21 PM, Anthony Liguori wrote:
>
>> If we also get rid of the savannah git repo, or plan to do so, I have
>> no issue with reverting this patch.
>
> If someone can suggest a solution for mailing list hosting, I'd be happy
> to leave Savannah tomorrow.

There is still the problem that

   "git.savannah.nongnu.org" qemu -site:savannah.nongnu.org

returns 6 times more hits than

   "git.qemu.org" -site:qemu.org

On one hand, this would be in favor of keeping my patch (savannah users 
cannot get submodules correctly); on the other hand, it means that 
leaving Savannah is not so easy.

If you prefer that, go ahead and revert it.

Paolo