From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NpdrZ-0000RR-S7
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 03:35:25 -0500
Received: from [199.232.76.173] (port=43603 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NpdrY-0000QP-IG
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 03:35:25 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <avi@redhat.com>) id 1NpdrY-0002q4-0M
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 03:35:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31086)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NpdrX-0002q0-I5
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 03:35:23 -0500
Message-ID: <4B98AB49.4030209@redhat.com>
Date: Thu, 11 Mar 2010 10:35:21 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20100309015343.901738854@redhat.com>
	<20100309015644.133975091@redhat.com>
In-Reply-To: <20100309015644.133975091@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch 1/3] target-i386: print EFER in
	cpu_dump_state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 03/09/2010 03:53 AM, Marcelo Tosatti wrote:
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
> Index: qemu-kvm-uq/target-i386/helper.c
> ===================================================================
> --- qemu-kvm-uq.orig/target-i386/helper.c
> +++ qemu-kvm-uq/target-i386/helper.c
> @@ -1176,6 +1176,7 @@ void cpu_dump_state(CPUState *env, FILE
>       cpu_x86_dump_seg_cache(env, f, cpu_fprintf, "TR",&env->tr);
>
>   #ifdef TARGET_X86_64
> +    cpu_fprintf(f, "EFER=    %016" PRIx64 "\n", env->efer);
>       if (env->hflags&  HF_LMA_MASK) {
>           cpu_fprintf(f, "GDT=     %016" PRIx64 " %08x\n",
>                       env->gdt.base, env->gdt.limit);
>
>    

Better to do this for i386 too, no?

-- 
error compiling committee.c: too many arguments to function