From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Npjn3-0000Xo-N1
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:55:09 -0500
Received: from [199.232.76.173] (port=59206 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Npjn3-0000Wb-1s
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:55:09 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Npjn1-0008PY-Nv
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:55:08 -0500
Received: from mail-qy0-f177.google.com ([209.85.221.177]:62458)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Npjn1-0008PS-C5
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:55:07 -0500
Received: by qyk7 with SMTP id 7so97023qyk.21
	for <qemu-devel@nongnu.org>; Thu, 11 Mar 2010 06:55:06 -0800 (PST)
Message-ID: <4B990445.5030303@codemonkey.ws>
Date: Thu, 11 Mar 2010 08:55:01 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4B98FA68.7000901@codemonkey.ws>
	<1268318923-13397-1-git-send-email-avi@redhat.com>
In-Reply-To: <1268318923-13397-1-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] CODING_STYLE: Reserve qemu_ prefix for
	library wrappers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/11/2010 08:48 AM, Avi Kivity wrote:
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   CODING_STYLE |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index a579cb1..92036f3 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -49,6 +49,9 @@ and is therefore likely to be changed.
>   Typedefs are used to eliminate the redundant 'struct' keyword.  It is the
>   QEMU coding style.
>
> +When wrapping standard library functions, use the prefix qemu_ to alert
> +readers that they are seeing a wrapped version; otherwise avoid this prefix.
> +
>    

Acked-by: Anthony Liguori <aliguori@us.ibm.com>

But I'd like to also see others agree with this.

Regards,

Anthony Liguori

>   4. Block structure
>
>   Every indented statement is braced; even if the block contains just one
>