From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NpkB0-0005FX-Hy for qemu-devel@nongnu.org; Thu, 11 Mar 2010 10:19:54 -0500 Received: from [199.232.76.173] (port=53949 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NpkAz-0005Eh-Qp for qemu-devel@nongnu.org; Thu, 11 Mar 2010 10:19:53 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NpkAz-0002Qq-1p for qemu-devel@nongnu.org; Thu, 11 Mar 2010 10:19:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34388) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NpkAy-0002Qa-Kq for qemu-devel@nongnu.org; Thu, 11 Mar 2010 10:19:52 -0500 Message-ID: <4B990A0C.5040109@redhat.com> Date: Thu, 11 Mar 2010 17:19:40 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists References: <1268239869-16058-1-git-send-email-aliguori@us.ibm.com> <201003111257.59828.paul@codesourcery.com> <4B98F99F.1000506@codemonkey.ws> <201003111419.53494.paul@codesourcery.com> <4B99041F.7030800@codemonkey.ws> In-Reply-To: <4B99041F.7030800@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Anthony Liguori , Gerd Hoffman , Paul Brook , Luiz Capitulino On 03/11/2010 04:54 PM, Anthony Liguori wrote: >>> I take it your not opposed to converting QEMUBH to be a QEMUNotifier? >>> If so, I'm happy to do it. >> It's unclear to me why you've invented a new thing in the first place. > > This style of callback has a number of advantages: > > - It provides better type safety since > - It's a more compact representation > - It maps to a function object (functor) which is a pretty common > pattern in most high level languages - The name isn't an eyesore -- error compiling committee.c: too many arguments to function