From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Npp12-0005h3-9c
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 15:29:56 -0500
Received: from [199.232.76.173] (port=56596 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Npp11-0005gh-Re
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 15:29:55 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Npp10-0003wp-0R
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 15:29:55 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:37238)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Npp0z-0003wf-Pj
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 15:29:53 -0500
Received: by gyh3 with SMTP id 3so229498gyh.4
	for <qemu-devel@nongnu.org>; Thu, 11 Mar 2010 12:29:51 -0800 (PST)
Message-ID: <4B995247.5010306@codemonkey.ws>
Date: Thu, 11 Mar 2010 14:27:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] migration: unix migration should obey
	autostart are the other ones
References: <cover.1268176134.git.quintela@redhat.com>
	<df010a71b58fcd4ae080fed1652daef2a74b1ec2.1268176134.git.quintela@redhat.com>
In-Reply-To: <df010a71b58fcd4ae080fed1652daef2a74b1ec2.1268176134.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/09/2010 05:10 PM, Juan Quintela wrote:
> This was the only incoming migration without autostart check
>
> Signed-off-by: Juan Quintela<quintela@redhat.com>
> ---
>   migration-unix.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/migration-unix.c b/migration-unix.c
> index ce59a2a..49de1b9 100644
> --- a/migration-unix.c
> +++ b/migration-unix.c
> @@ -176,6 +176,8 @@ static void unix_accept_incoming_migration(void *opaque)
>       qemu_announce_self();
>       DPRINTF("successfully loaded vm state\n");
>
> +    if (autostart)
> +        vm_start();
>    

Maybe a better thing to do is make accept_incoming_migration return an 
error code and do the vm_start in common code.

Regards,

Anthony Liguori

>   out_fopen:
>       qemu_fclose(f);
>