From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nq3ag-0006AV-If
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 07:03:42 -0500
Received: from [199.232.76.173] (port=58346 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nq3ag-0006A3-66
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 07:03:42 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <paolo.bonzini@gmail.com>) id 1Nq3ad-0008Kf-Ge
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 07:03:41 -0500
Received: from mail-fx0-f211.google.com ([209.85.220.211]:41398)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Nq3ad-0008KV-6q
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 07:03:39 -0500
Received: by fxm3 with SMTP id 3so405932fxm.16
	for <qemu-devel@nongnu.org>; Fri, 12 Mar 2010 04:03:38 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4B9A2D92.2080304@redhat.com>
Date: Fri, 12 Mar 2010 13:03:30 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1268318674-10607-1-git-send-email-nsprei@redhat.com>
In-Reply-To: <1268318674-10607-1-git-send-email-nsprei@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] read-only: minor cleanup
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/11/2010 03:44 PM, Naphtali Sprei wrote:
>           case 'r':
>               readonly = true;
> +            flags &= BDRV_O_RDWR;

I'm pretty sure a ~ is missing there. :-)

Paolo