From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nq4ol-0005Np-3x
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:22:19 -0500
Received: from [199.232.76.173] (port=43780 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nq4ok-0005NO-Ci
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:22:18 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <paolo.bonzini@gmail.com>) id 1Nq4oj-0006j2-8e
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:22:18 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:13873)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Nq4oj-0006ip-0T
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:22:17 -0500
Received: by qw-out-1920.google.com with SMTP id 5so362482qwf.4
	for <qemu-devel@nongnu.org>; Fri, 12 Mar 2010 05:22:16 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4B9A4003.9030908@redhat.com>
Date: Fri, 12 Mar 2010 14:22:11 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <a38b25541003120338l54f1f12fq3afde9424ed76955@mail.gmail.com>
In-Reply-To: <a38b25541003120338l54f1f12fq3afde9424ed76955@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] target-i386: fix commit
	c22549204a6edc431e8e4358e61bd56386ff6957
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 03/12/2010 12:38 PM, TeLeMan wrote:
> The commit c22549204a6edc431e8e4358e61bd56386ff6957 led movntps&
> movntdq to be translated incorrectly.

This should go on stable-0.12 too.

Paolo

> Signed-off-by: TeLeMan<geleman@gmail.com>
> ---
>   target-i386/translate.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 6838d53..07b0a70 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -3457,6 +3457,11 @@ static void gen_sse(DisasContext *s, int b,
> target_ulong pc_start, int rex_r)
>           case 0x1e7: /* movntdq */
>           case 0x02b: /* movntps */
>           case 0x12b: /* movntps */
> +            if (mod == 3)
> +                goto illegal_op;
> +            gen_lea_modrm(s, modrm,&reg_addr,&offset_addr);
> +            gen_sto_env_A0(s->mem_index, offsetof(CPUX86State,xmm_regs[reg]));
> +            break;
>           case 0x3f0: /* lddqu */
>               if (mod == 3)
>                   goto illegal_op;