From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqD1L-0004dR-9S for qemu-devel@nongnu.org; Fri, 12 Mar 2010 17:07:51 -0500 Received: from [199.232.76.173] (port=52161 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqD1K-0004dJ-U6 for qemu-devel@nongnu.org; Fri, 12 Mar 2010 17:07:50 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NqD1J-0002He-Px for qemu-devel@nongnu.org; Fri, 12 Mar 2010 17:07:50 -0500 Received: from mail.fgznet.ch ([81.92.96.47]:58041 helo=smtp.fgznet.ch) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NqD1J-0002HG-DL for qemu-devel@nongnu.org; Fri, 12 Mar 2010 17:07:49 -0500 Message-ID: <4B9ABB1F.7010906@fgznet.ch> Date: Fri, 12 Mar 2010 23:07:27 +0100 From: Andreas Tobler MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes References: <20100312215015.GA29285@triton8.kn-bremen.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Juergen Lock , qemu-devel@nongnu.org On 12.03.10 22:59, malc wrote: > On Fri, 12 Mar 2010, Juergen Lock wrote: > >> This fixes commit e4ee916d3f9a93df06bd498c92767c1558d59a0b. >> (The bug was mine actually...) >> >> Submitted by: Andreas Tobler >> >> Signed-off-by: Juergen Lock >> >> --- a/cache-utils.c >> +++ b/cache-utils.c >> @@ -58,7 +58,10 @@ static void ppc_init_cacheline_sizes(voi >> #endif >> >> #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) >> +#include >> #include >> +#include > > And stdlib is needed for what exactly? To avoid this one: cache-utils.c: In function 'ppc_init_cacheline_sizes': cache-utils.c:76: warning: implicit declaration of function 'exit' Andreas