From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nqa7w-0007bd-KC
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 17:48:12 -0500
Received: from [199.232.76.173] (port=38577 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nqa7w-0007b6-4T
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 17:48:12 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <weil@mail.berlios.de>) id 1Nqa7u-00035a-PW
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 17:48:11 -0500
Received: from moutng.kundenserver.de ([212.227.126.186]:63284)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1Nqa7u-00035S-8m
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 17:48:10 -0500
Message-ID: <4B9C1623.7030106@mail.berlios.de>
Date: Sat, 13 Mar 2010 23:48:03 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5/6] Implement multi-level page tables.
References: <cover.1268265556.git.rth@twiddle.net>
	<463ebb8d6c9bd5b65a804785002929eb9c98a321.1268265556.git.rth@twiddle.net>
In-Reply-To: <463ebb8d6c9bd5b65a804785002929eb9c98a321.1268265556.git.rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com

Richard Henderson schrieb:
> Define L1_MAP_ADDR_SPACE_BITS to be either the virtual address size
> (in user mode) or physical address size (in system mode), and use
> that to size l1_map.  This rewrites page_find_alloc, page_flush_tb,
> and walk_memory_regions.
>
> Use TARGET_PHYS_ADDR_SPACE_BITS for the physical memory map based
> off of l1_phys_map.  This rewrites page_phys_find_alloc and
> phys_page_for_each.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  cpu-all.h |    7 +-
>  exec.c    |  451 +++++++++++++++++++++++++++++++++++++------------------------
>  2 files changed, 278 insertions(+), 180 deletions(-)

This patch breaks remote debugging (QEMU crash).

Test scenario:

x86_64 debian host, mips malta (32/64 bit, big/little endian) target

start qemu system emulation with a malta kernel and options -s -S,
attach remote debugger, start mips kernel with "c" in debugger =>
qemu crash:

page_flush_tb is filled with zero in page_flush_tb
tb_phys_invalidate is called, access fault in tb_remove.

Other targets might be affected, too.

Regards,
Stefan Weil